From: Vlad Yasevich <vladislav.yasevich@hp.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH] fix sctp breakage
Date: Wed, 18 Mar 2009 08:28:44 -0400 [thread overview]
Message-ID: <49C0E8FC.70706@hp.com> (raw)
In-Reply-To: <20090318031405.GX28946@ZenIV.linux.org.uk>
Al Viro wrote:
> broken by commit 5e739d1752aca4e8f3e794d431503bfca3162df4; AFAICS should
> be -stable fodder as well...
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> diff --git a/net/sctp/endpointola.c b/net/sctp/endpointola.c
> index 4c8d9f4..905fda5 100644
> --- a/net/sctp/endpointola.c
> +++ b/net/sctp/endpointola.c
> @@ -111,7 +111,8 @@ static struct sctp_endpoint *sctp_endpoint_init(struct sctp_endpoint *ep,
> if (sctp_addip_enable) {
> auth_chunks->chunks[0] = SCTP_CID_ASCONF;
> auth_chunks->chunks[1] = SCTP_CID_ASCONF_ACK;
> - auth_chunks->param_hdr.length += htons(2);
> + auth_chunks->param_hdr.length =
> + htons(sizeof(sctp_paramhdr_t) + 2);
> }
> }
>
ACK. That wasn't a good way to write that increment. I should have thought more
about it, but at the time it seemed like a good idea...
Thanks
-vlad
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2009-03-18 12:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-18 3:14 [PATCH] fix sctp breakage Al Viro
2009-03-18 3:25 ` Al Viro
2009-03-18 12:28 ` Vlad Yasevich [this message]
2009-03-19 2:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C0E8FC.70706@hp.com \
--to=vladislav.yasevich@hp.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).