From: Yang Hongyang <yanghy@cn.fujitsu.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: David Miller <davem@davemloft.net>,
chas@cmf.nrl.navy.mil, netdev@vger.kernel.org
Subject: Re: [PATCH] atm: lec use dev_change_mtu
Date: Fri, 20 Mar 2009 15:26:34 +0800 [thread overview]
Message-ID: <49C3452A.8000709@cn.fujitsu.com> (raw)
In-Reply-To: <20090319172400.239594f8@nehalam>
Stephen Hemminger wrote:
> Rather than calling device pointer directly (which is incorrect with
> net_device_ops), use the standard dev_change_mtu. Compile tested only.
^^^^^^^^^^^^Should it be dev_set_mtu?
>
> Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
>
> --- a/net/atm/lec.c 2009-03-19 17:18:35.140652628 -0700
> +++ b/net/atm/lec.c 2009-03-19 17:19:19.500777355 -0700
> @@ -502,7 +502,7 @@ static int lec_atm_send(struct atm_vcc *
> priv->lane2_ops = NULL;
> if (priv->lane_version > 1)
> priv->lane2_ops = &lane2_ops;
> - if (dev->change_mtu(dev, mesg->content.config.mtu))
> + if (dev_set_mtu(dev, mesg->content.config.mtu))
> printk("%s: change_mtu to %d failed\n", dev->name,
> mesg->content.config.mtu);
> priv->is_proxy = mesg->content.config.is_proxy;
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
--
Regards
Yang Hongyang
next prev parent reply other threads:[~2009-03-20 7:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 0:24 [PATCH] atm: lec use dev_change_mtu Stephen Hemminger
2009-03-20 7:26 ` Yang Hongyang [this message]
2009-03-20 7:45 ` Yang Hongyang
2009-03-20 7:48 ` David Miller
2009-03-20 7:59 ` Yang Hongyang
2009-03-21 20:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C3452A.8000709@cn.fujitsu.com \
--to=yanghy@cn.fujitsu.com \
--cc=chas@cmf.nrl.navy.mil \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).