From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yang Hongyang Subject: Re: [PATCH]: sunvnet netdev ops conversion... Date: Fri, 20 Mar 2009 16:30:59 +0800 Message-ID: <49C35443.8020604@cn.fujitsu.com> References: <20090320.005205.65922171.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: David Miller Return-path: Received: from cn.fujitsu.com ([222.73.24.84]:49866 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1754676AbZCTIbt (ORCPT ); Fri, 20 Mar 2009 04:31:49 -0400 In-Reply-To: <20090320.005205.65922171.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: David Miller wrote: > Committed to net-next-2.6... > > sunvnet: Convert to net_device_ops. I noticed that there are other drivers's net_device_ops need to be converted,is these convert nessary? > > Signed-off-by: David S. Miller > --- > drivers/net/sunvnet.c | 18 +++++++++++------- > 1 files changed, 11 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/sunvnet.c b/drivers/net/sunvnet.c > index 611230f..a82fb2a 100644 > --- a/drivers/net/sunvnet.c > +++ b/drivers/net/sunvnet.c > @@ -1012,6 +1012,16 @@ err_out: > static LIST_HEAD(vnet_list); > static DEFINE_MUTEX(vnet_list_mutex); > > +static const struct net_device_ops vnet_ops = { > + .ndo_open = vnet_open, > + .ndo_stop = vnet_close, > + .ndo_set_multicast_list = vnet_set_rx_mode, > + .ndo_set_mac_address = vnet_set_mac_addr, > + .ndo_tx_timeout = vnet_tx_timeout, > + .ndo_change_mtu = vnet_change_mtu, > + .ndo_start_xmit = vnet_start_xmit, > +}; > + > static struct vnet * __devinit vnet_new(const u64 *local_mac) > { > struct net_device *dev; > @@ -1040,15 +1050,9 @@ static struct vnet * __devinit vnet_new(const u64 *local_mac) > INIT_LIST_HEAD(&vp->list); > vp->local_mac = *local_mac; > > - dev->open = vnet_open; > - dev->stop = vnet_close; > - dev->set_multicast_list = vnet_set_rx_mode; > - dev->set_mac_address = vnet_set_mac_addr; > - dev->tx_timeout = vnet_tx_timeout; > + dev->netdev_ops = &vnet_ops; > dev->ethtool_ops = &vnet_ethtool_ops; > dev->watchdog_timeo = VNET_TX_TIMEOUT; > - dev->change_mtu = vnet_change_mtu; > - dev->hard_start_xmit = vnet_start_xmit; > > err = register_netdev(dev); > if (err) { -- Regards Yang Hongyang