From: Eric Dumazet <dada1@cosmosbay.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: David Miller <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [NET] net: reorder struct net_device_ops
Date: Fri, 20 Mar 2009 13:53:45 +0100 [thread overview]
Message-ID: <49C391D9.20308@cosmosbay.com> (raw)
In-Reply-To: <87iqm4jr8z.fsf@nemi.mork.no>
Bjørn Mork a écrit :
> Eric Dumazet <dada1@cosmosbay.com> writes:
>
>> [NET] net: reorder struct net_device_ops
>>
>> Moving ndo_start_xmit() field at first position in
>> struct net_device_ops reduce the assembly needed to compute
>> the prefetch() address.
>
> You can't do this while the compatibility code is still there.
>
> from net/core/dev.c:register_netdevice() :
>
> /* This works only because net_device_ops and the
> compatiablity structure are the same. */
> dev->netdev_ops = (void *) &(dev->init);
>
>
> Bjørn
Nice catch !
Yes, very true, but I discarded this patch anyway, I wont correct this.
Thank you
prev parent reply other threads:[~2009-03-20 12:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-20 8:32 [PATCH] net: remove useless prefetch() call Eric Dumazet
2009-03-20 8:36 ` David Miller
2009-03-20 9:44 ` [NET] net: reorder struct net_device_ops Eric Dumazet
2009-03-20 10:07 ` [PATCH] net: remove useless prefetch() call Eric Dumazet
2009-03-21 20:43 ` David Miller
2009-03-20 12:47 ` [NET] net: reorder struct net_device_ops Bjørn Mork
2009-03-20 12:53 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C391D9.20308@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).