From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: mhw@netris.org, netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] netfilter: fix unaligned memory access in tcp_sack
Date: Mon, 23 Mar 2009 13:48:24 +0100 [thread overview]
Message-ID: <49C78518.2010106@trash.net> (raw)
In-Reply-To: <20090322.211730.224794112.davem@davemloft.net>
David Miller wrote:
> From: "Mark H. Weaver" <mhw@netris.org>
> Date: Sun, 22 Mar 2009 23:09:51 -0400
>
>> This patch fixes an unaligned memory access in tcp_sack while reading
>> sequence numbers from TCP selective acknowledgement options. Prior to
>> applying this patch, upstream linux-2.6.27.20 was occasionally
>> generating messages like this on my sparc64 system:
>>
>> [54678.532071] Kernel unaligned access at TPC[6b17d4] tcp_packet+0xcd4/0xd00
>>
>> More details provided upon request. Apologies in advance if I've sent
>> this to the wrong place or not followed proper procedures.
>
> Acked-by: David S. Miller <davem@davemloft.net>
Looks good to me. Dave, please apply directly or pull from:
git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-2.6.git
Thanks!
next prev parent reply other threads:[~2009-03-23 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-23 3:09 [PATCH] netfilter: fix unaligned memory access in tcp_sack Mark H. Weaver
2009-03-23 4:17 ` David Miller
2009-03-23 12:48 ` Patrick McHardy [this message]
2009-03-24 23:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C78518.2010106@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=mhw@netris.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).