netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Dan Williams <dcbw@redhat.com>
Cc: Matt Domsch <Matt_Domsch@dell.com>,
	netdev@vger.kernel.org, linux-hotplug@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: Network Device Naming mechanism and policy
Date: Tue, 24 Mar 2009 18:04:14 +0100	[thread overview]
Message-ID: <49C9128E.6040202@trash.net> (raw)
In-Reply-To: <1237912858.9082.39.camel@localhost.localdomain>

Dan Williams wrote:
> On Tue, 2009-03-24 at 17:21 +0100, Patrick McHardy wrote:
>> I would classify this as a bug, especially the fact that udev doesn't
>> undo a failed rename, so you end up with ethX_rename. Virtual devices
>> using the same MAC address trigger this reliably unless you add
>> exceptions to the udev rules.
> 
> Any particular reason the MAC addresses are the same?  This came up a
> while ago with the 'dnet' device in the thread "Dave DNET ethernet
> controller".
> 
> If the MAC address isn't a UUID for the device, then *what* is?

Sometimes (I was referring to virtual devices) there may not be
one, thats correct.

> If there isn't one, then certainly udev can't be blamed for getting
> ordering or names wrong, because there's nothing to use to actually
> match up the device to a name, uniquely. 

I agree that udev can't do anything useful in that case. I would
prefer it it wouldn't even try though instead of messing with the
names and leaving a bunch of _rename devices around. Sure, I can
add a rule to disable it, but that shouldn't be necessary.

Generally, I'm wondering whether it should touch virtual network
devices at all since the MAC addresses are often not persistent,
sometimes not unique and the name might have already been chosen
explicitly by the administrator when creating the device.

Currently there are some rules to ignore a couple of known virtual
devices types. Are there actually cases where renaming virtual
devices is desired? Otherwise a more future-proof way than
blacklisting each type individually would be to add some attribute
informing udev that the device has no unique key and should be
ignored.


  parent reply	other threads:[~2009-03-24 17:04 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-24 15:46 Network Device Naming mechanism and policy Matt Domsch
2009-03-24 16:21 ` Patrick McHardy
2009-03-24 16:28   ` Kay Sievers
2009-03-24 16:38     ` Patrick McHardy
2009-03-24 16:40   ` Dan Williams
2009-03-24 17:00     ` Alan Cox
2009-03-24 17:04     ` Patrick McHardy [this message]
2009-03-24 18:51     ` david
2009-03-24 21:02       ` Alan Cox
2009-03-24 23:14         ` Greg KH
2009-03-24 16:42 ` Karl O. Pinc
2009-03-24 17:45   ` Matt Domsch
2009-03-24 17:02 ` Scott James Remnant
2009-03-24 17:52   ` Matt Domsch
2009-03-24 18:12     ` Bill Nottingham
2009-03-24 18:20       ` Scott James Remnant
2009-03-24 18:49 ` david
2009-03-24 19:22   ` Matt Domsch
2009-03-24 22:57 ` David Miller
2009-03-25 20:22   ` Chris Friesen
2009-03-26 20:17     ` Dan Williams
2009-03-26 16:39   ` Matt Domsch
2009-03-26 20:16     ` Dan Williams
2009-03-27 16:06       ` Len Brown
2009-04-09 14:58   ` Matt Domsch
2009-03-31 14:07 ` Kurt Van Dijck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49C9128E.6040202@trash.net \
    --to=kaber@trash.net \
    --cc=Matt_Domsch@dell.com \
    --cc=dcbw@redhat.com \
    --cc=linux-hotplug@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).