From: Frank Blaschka <blaschka@linux.vnet.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [patch 0/6] s390: qeth fixes for 2.6.30
Date: Wed, 25 Mar 2009 09:25:14 +0100 [thread overview]
Message-ID: <49C9EA6A.90808@linux.vnet.ibm.com> (raw)
In-Reply-To: <20090325.000817.183932373.davem@davemloft.net>
> Any particular reason you wait until right when the
> merge window opens to send me stuff?
>
> I said on netdev that I wanted to empty my patchwork
> queue then submit the tree to Linus.
>
> So then you send me more stuff on top of that? :-/
>
> Please don't wait until the last moment next time.
Sorry, this was by accident. Next time I will send the patches
sooner.
> Applied.
>
>> Frank Blaschka (2)
>> qeth: add statistics for tx csum
>> qeth: remove EDDP
>
> Your EDDP was slow because the implementation was incredibly
> sub-optimal. %90 of the code is doing copies and fiddling
> with SKB internals.
I did not wrote the EDDP code but this was my impression too. Thanks for
confirming my study. Also the filling of the hardware buffers was not
efficient and passing more buffers to the hw was expensive too.
next prev parent reply other threads:[~2009-03-25 8:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 6:57 [patch 0/6] s390: qeth fixes for 2.6.30 frank.blaschka
2009-03-25 6:57 ` [patch 1/6] [PATCH] qeth: struct device - replace bus_id with dev_name(), dev_set_name() frank.blaschka
2009-03-25 6:57 ` [patch 2/6] [PATCH] qeth: add statistics for tx csum frank.blaschka
2009-03-25 6:57 ` [patch 3/6] [PATCH] qeth: remove EDDP frank.blaschka
2009-03-25 6:57 ` [patch 4/6] [PATCH] qeth: unregister MAC addresses during recovery frank.blaschka
2009-03-25 6:57 ` [patch 5/6] [PATCH] qeth: check for completion of a running recovery frank.blaschka
2009-03-25 6:57 ` [patch 6/6] [PATCH] qeth: fix wait_event_timeout handling frank.blaschka
2009-03-25 7:08 ` [patch 0/6] s390: qeth fixes for 2.6.30 David Miller
2009-03-25 8:25 ` Frank Blaschka [this message]
2009-03-25 23:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49C9EA6A.90808@linux.vnet.ibm.com \
--to=blaschka@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).