netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [ANNOUNCE] iproute2 v2.6.29
@ 2009-03-24 22:34 Stephen Hemminger
  2009-03-24 22:38 ` David Miller
  2009-03-25 16:32 ` Oliver Hartkopp
  0 siblings, 2 replies; 5+ messages in thread
From: Stephen Hemminger @ 2009-03-24 22:34 UTC (permalink / raw)
  To: netdev; +Cc: linux-net, linux-kernel

Trying to stay on top of things (for a change).

New version of iproute2 utilities that includes bug fixes and
support for all the new features in kernel 2.6.29.

  http://devresources.linux-foundation.org/dev/iproute2/download/iproute2-2.6.29.tar.bz2

Denys Fedoryschenko (1):
      Fix memory leak in local options

Jamal Hadi Salim (1):
      Breakage noticed when debian upgraded to xtables (iptables > 1.4.1)

Patrick McHardy (1):
      iproute: add DRR support

Stephen Hemminger (7):
      fix uninitialized memory in tc_skbedit
      Add missing limits.h
      Add DHCP as routing protocol
      Add support for IFALIAS
      Handle default hoplimit
      Use sanatized headers from 2.6.29
      Update snapshot

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [ANNOUNCE] iproute2 v2.6.29
  2009-03-24 22:34 [ANNOUNCE] iproute2 v2.6.29 Stephen Hemminger
@ 2009-03-24 22:38 ` David Miller
  2009-03-24 22:48   ` Stephen Hemminger
  2009-03-25 16:32 ` Oliver Hartkopp
  1 sibling, 1 reply; 5+ messages in thread
From: David Miller @ 2009-03-24 22:38 UTC (permalink / raw)
  To: shemminger; +Cc: netdev, linux-net, linux-kernel

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Tue, 24 Mar 2009 15:34:27 -0700

> Trying to stay on top of things (for a change).
> 
> New version of iproute2 utilities that includes bug fixes and
> support for all the new features in kernel 2.6.29.
> 
>   http://devresources.linux-foundation.org/dev/iproute2/download/iproute2-2.6.29.tar.bz2

Some build failures here:

gcc -D_GNU_SOURCE -O2 -Wstrict-prototypes -Wall -I../include -DRESOLVE_HOSTNAMES -DLIBDIR=\"/usr/lib/\"   -c -o link_gre.o link_gre.c
In file included from link_gre.c:15:
../include/linux/if_tunnel.h:33: error: field ‘iph’ has incomplete type
link_gre.c: In function ‘gre_parse_opt’:
link_gre.c:136: warning: implicit declaration of function ‘__constant_htons’

I seem to remember messing with the kernel headers in this
area recently... yes, indeed:

commit 0afd4a21ba7d75e93fa79cf05d7a21774e149c0f
Author: David S. Miller <davem@davemloft.net>
Date:   Mon Feb 2 13:27:44 2009 -0800

    net: Fix userland breakage wrt. linux/if_tunnel.h
    
    Reported by Andrew Walrond <andrew@walrond.org>
    
    Changeset c19e654ddbe3831252f61e76a74d661e1a755530
    ("gre: Add netlink interface") added an include
    of linux/ip.h to linux/if_tunnel.h
    
    We can't really let that get exposed to userspace
    because this conflicts with types defined in netinet/ip.h
    which userland is almost certainly going to have included
    either explicitly or implicitly.
    
    So guard this include with a __KERNEL__ ifdef.
    
    Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/include/linux/Kbuild b/include/linux/Kbuild
index 12e9a29..6a9bb97 100644
--- a/include/linux/Kbuild
+++ b/include/linux/Kbuild
@@ -89,7 +89,6 @@ header-y += if_ppp.h
 header-y += if_slip.h
 header-y += if_strip.h
 header-y += if_tun.h
-header-y += if_tunnel.h
 header-y += in_route.h
 header-y += ioctl.h
 header-y += ip6_tunnel.h
@@ -235,6 +234,7 @@ unifdef-y += if_phonet.h
 unifdef-y += if_pppol2tp.h
 unifdef-y += if_pppox.h
 unifdef-y += if_tr.h
+unifdef-y += if_tunnel.h
 unifdef-y += if_vlan.h
 unifdef-y += igmp.h
 unifdef-y += inet_diag.h
diff --git a/include/linux/if_tunnel.h b/include/linux/if_tunnel.h
index aeab2cb..82c4362 100644
--- a/include/linux/if_tunnel.h
+++ b/include/linux/if_tunnel.h
@@ -2,7 +2,10 @@
 #define _IF_TUNNEL_H_
 
 #include <linux/types.h>
+
+#ifdef __KERNEL__
 #include <linux/ip.h>
+#endif
 
 #define SIOCGETTUNNEL   (SIOCDEVPRIVATE + 0)
 #define SIOCADDTUNNEL   (SIOCDEVPRIVATE + 1)

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [ANNOUNCE] iproute2 v2.6.29
  2009-03-24 22:38 ` David Miller
@ 2009-03-24 22:48   ` Stephen Hemminger
  0 siblings, 0 replies; 5+ messages in thread
From: Stephen Hemminger @ 2009-03-24 22:48 UTC (permalink / raw)
  To: David Miller; +Cc: netdev, linux-net, linux-kernel

On Tue, 24 Mar 2009 15:38:22 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> From: Stephen Hemminger <shemminger@vyatta.com>
> Date: Tue, 24 Mar 2009 15:34:27 -0700
> 
> > Trying to stay on top of things (for a change).
> > 
> > New version of iproute2 utilities that includes bug fixes and
> > support for all the new features in kernel 2.6.29.
> > 
> >   http://devresources.linux-foundation.org/dev/iproute2/download/iproute2-2.6.29.tar.bz2
> 

Thanks including <linux/ip.h> fixed that.

  http://devresources.linux-foundation.org/dev/iproute2/download/iproute2-2.6.29-1.tar.bz2

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [ANNOUNCE] iproute2 v2.6.29
  2009-03-24 22:34 [ANNOUNCE] iproute2 v2.6.29 Stephen Hemminger
  2009-03-24 22:38 ` David Miller
@ 2009-03-25 16:32 ` Oliver Hartkopp
  2009-03-26 10:01   ` Varun Chandramohan
  1 sibling, 1 reply; 5+ messages in thread
From: Oliver Hartkopp @ 2009-03-25 16:32 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev

Stephen Hemminger wrote:
> Trying to stay on top of things (for a change).
> 
> New version of iproute2 utilities that includes bug fixes and
> support for all the new features in kernel 2.6.29.
> 
>   http://devresources.linux-foundation.org/dev/iproute2/download/iproute2-2.6.29.tar.bz2
> 
> Denys Fedoryschenko (1):
>       Fix memory leak in local options
> 
> Jamal Hadi Salim (1):
>       Breakage noticed when debian upgraded to xtables (iptables > 1.4.1)
> 
> Patrick McHardy (1):
>       iproute: add DRR support
> 
> Stephen Hemminger (7):
>       fix uninitialized memory in tc_skbedit
>       Add missing limits.h
>       Add DHCP as routing protocol
>       Add support for IFALIAS
>       Handle default hoplimit
>       Use sanatized headers from 2.6.29
>       Update snapshot

Hi Stephen,

the CAN stuff i mailed to you is still missing.

Sigh.

Oliver


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [ANNOUNCE] iproute2 v2.6.29
  2009-03-25 16:32 ` Oliver Hartkopp
@ 2009-03-26 10:01   ` Varun Chandramohan
  0 siblings, 0 replies; 5+ messages in thread
From: Varun Chandramohan @ 2009-03-26 10:01 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: netdev

Oliver Hartkopp wrote:
> Stephen Hemminger wrote:
>   
>> Trying to stay on top of things (for a change).
>>
>> New version of iproute2 utilities that includes bug fixes and
>> support for all the new features in kernel 2.6.29.
>>
>>   http://devresources.linux-foundation.org/dev/iproute2/download/iproute2-2.6.29.tar.bz2
>>
>> Denys Fedoryschenko (1):
>>       Fix memory leak in local options
>>
>> Jamal Hadi Salim (1):
>>       Breakage noticed when debian upgraded to xtables (iptables > 1.4.1)
>>
>> Patrick McHardy (1):
>>       iproute: add DRR support
>>
>> Stephen Hemminger (7):
>>       fix uninitialized memory in tc_skbedit
>>       Add missing limits.h
>>       Add DHCP as routing protocol
>>       Add support for IFALIAS
>>       Handle default hoplimit
>>       Use sanatized headers from 2.6.29
>>       Update snapshot
>>     
>
>   
Hi Stephen,
         
                      I noticed that you have missed out on 2 patches i 
submitted. Incase it slipped through can you please look into it?

http://patchwork.ozlabs.org/patch/24337/
http://patchwork.ozlabs.org/patch/24338/


Regards,
Varun

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-03-26 10:01 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-24 22:34 [ANNOUNCE] iproute2 v2.6.29 Stephen Hemminger
2009-03-24 22:38 ` David Miller
2009-03-24 22:48   ` Stephen Hemminger
2009-03-25 16:32 ` Oliver Hartkopp
2009-03-26 10:01   ` Varun Chandramohan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).