From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] bonding: allow bond in mode balance-alb to work properly in bridge -try4 Date: Fri, 27 Mar 2009 08:53:13 +0100 Message-ID: <49CC85E9.7070903@trash.net> References: <20090313183303.GF3436@psychotron.englab.brq.redhat.com> <20090326155205.GA28868@psychotron.englab.brq.redhat.com> <20090327.003819.234492275.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: jpirko@redhat.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jgarzik@pobox.com, shemminger@linux-foundation.org, bridge@lists.linux-foundation.org, fubar@us.ibm.com, bonding-devel@lists.sourceforge.net, mschmidt@redhat.com, dada1@cosmosbay.com To: David Miller Return-path: Received: from stinky.trash.net ([213.144.137.162]:52636 "EHLO stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755789AbZC0HxY (ORCPT ); Fri, 27 Mar 2009 03:53:24 -0400 In-Reply-To: <20090327.003819.234492275.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: David Miller wrote: > From: Jiri Pirko > Date: Thu, 26 Mar 2009 16:52:06 +0100 > >> (resend, updated changelog, hook moved into skb_bond_should_drop, >> skb_bond_should_drop ifdefed) >> >> Hi all. >> >> The problem is described in following bugzilla: >> https://bugzilla.redhat.com/show_bug.cgi?id=487763 > ... >> This patch solves the situation in the bonding without touching bridge code, >> as Patrick suggested. For every incoming frame to bonding it searches the >> destination address in slaves list and if any of slave addresses matches, it >> rewrites the address in frame by the adress of bonding master. This ensures that >> all frames comming thru the bonding in alb mode have the same address. >> >> Signed-off-by: Jiri Pirko > > > I don't like the hook, but if that's how it's best done.... > > Patrick, please review this. Me neither, but I don't think this approach can be done without the hook. While I still find it questionable whether this mode really needs to be supported for a bridge at all, an alternative approach would be to have bonding add FDB entries for all secondary MACs to make bridging treat them as local.