From: Larry Finger <Larry.Finger@lwfinger.net>
To: Oliver Neukum <oliver@neukum.org>
Cc: jgarzik@pobox.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] kaweth: Fix locking to be SMP-safe
Date: Mon, 30 Mar 2009 10:58:28 -0500 [thread overview]
Message-ID: <49D0EC24.4080206@lwfinger.net> (raw)
In-Reply-To: <200903300828.45337.oliver@neukum.org>
Oliver Neukum wrote:
> Am Montag 30 März 2009 01:32:34 schrieb Larry Finger:
>> On an SMP system, the following message is printed. The patch below gets
>> fixes the problem.
>
> Thanks for this report and the patch. I think, however that it introduces
> unneeded locking. It seems to me that we should be fine if we fix
> kaweth_start_xmit(). That code assumes that it is called with interrupts
> off and under a spinlock. Is that incorrect?
You are correct in that only the locking in kaweth_start_xmit() needs to be
changed to lock out the other CPU's. In my testing under extreme conditions (X
server over the network), the interface stalled with no logged messages. My
other changes in the locking were an unsuccessful attempt to fix that and have
been removed. Version 2 of the patches will be sent after I finish testing.
Thanks,
Larry
next prev parent reply other threads:[~2009-03-30 15:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-29 23:32 [PATCH 1/2] kaweth: Fix locking to be SMP-safe Larry Finger
2009-03-30 6:28 ` Oliver Neukum
2009-03-30 15:58 ` Larry Finger [this message]
2009-03-31 7:39 ` Oliver Neukum
2009-03-31 14:55 ` Larry Finger
2009-03-31 15:13 ` Oliver Neukum
2009-03-31 15:24 ` Larry Finger
2009-03-31 18:40 ` Larry Finger
2009-03-31 22:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D0EC24.4080206@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).