From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH] netfilter: finer grained nf_conn locking Date: Mon, 30 Mar 2009 21:20:47 +0200 Message-ID: <49D11B8F.8060402@cosmosbay.com> References: <20090218051906.174295181@vyatta.com> <20090218052747.679540125@vyatta.com> <499BDB5D.2050105@trash.net> <499C1894.7060400@cosmosbay.com> <49CE568A.9090104@cosmosbay.com> <49D11635.2050809@hp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Patrick McHardy , Stephen Hemminger , David Miller , netdev@vger.kernel.org, netfilter-devel@vger.kernel.org To: Rick Jones Return-path: In-Reply-To: <49D11635.2050809@hp.com> Sender: netfilter-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Rick Jones a =E9crit : > Eric Dumazet wrote: >> Hi Patrick >> >> Apparently we could not finish the removal of tcp_lock for 2.6.30 :( >> >> Stephen suggested using a 4 bytes hole in struct nf_conntrack, >> but this is ok only if sizeof(spinlock_t) <=3D 4 and 64 bit arches. >> >> We could do an hybrid thing : use nf_conn.ct_general.lock if 64 bit >> arches >> and sizeof(spinlock_t) <=3D 4. >> >> Other cases would use a carefuly sized array of spinlocks... >> >> Thank you >> >> [PATCH] netfilter: finer grained nf_conn locking >> >> Introduction of fine grained lock infrastructure for nf_conn. >> If possible, we use a 32bit hole on 64bit arches. >> Else we use a global array of hashed spinlocks, so we dont >> change size of "struct nf_conn" >> >> Get rid of central tcp_lock rwlock used in TCP conntracking >> using this infrastructure for better performance on SMP. >> >> "tbench 8" results on my 8 core machine (32bit kernel, with >> conntracking on) : 2319 MB/s instead of 2284 MB/s >=20 > Is this an implicit request for me to try to resurrect the 32-core se= tup? >=20 Not at all, just to keep you informed of work in progress :) -- To unsubscribe from this list: send the line "unsubscribe netfilter-dev= el" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html