* [PATCH] core: remove pointless conditional before kfree()
@ 2009-03-31 8:09 Wei Yongjun
2009-03-31 22:06 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2009-03-31 8:09 UTC (permalink / raw)
To: David Miller; +Cc: netdev
Remove pointless conditional before kfree().
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
---
net/core/ethtool.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/net/core/ethtool.c b/net/core/ethtool.c
index 244ca56..d9d5160 100644
--- a/net/core/ethtool.c
+++ b/net/core/ethtool.c
@@ -261,8 +261,7 @@ static int ethtool_get_rxnfc(struct net_device *dev, void __user *useraddr)
ret = 0;
err_out:
- if (rule_buf)
- kfree(rule_buf);
+ kfree(rule_buf);
return ret;
}
--
1.5.3.8
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] core: remove pointless conditional before kfree()
2009-03-31 8:09 [PATCH] core: remove pointless conditional before kfree() Wei Yongjun
@ 2009-03-31 22:06 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-03-31 22:06 UTC (permalink / raw)
To: yjwei; +Cc: netdev
From: Wei Yongjun <yjwei@cn.fujitsu.com>
Date: Tue, 31 Mar 2009 16:09:19 +0800
> Remove pointless conditional before kfree().
>
> Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-31 22:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-31 8:09 [PATCH] core: remove pointless conditional before kfree() Wei Yongjun
2009-03-31 22:06 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).