* [PATCH] hso: add Vendor/Product ID's for new devices @ 2009-03-31 11:56 Jan Dumon 2009-04-01 7:33 ` Paulius Zaleckas 0 siblings, 1 reply; 9+ messages in thread From: Jan Dumon @ 2009-03-31 11:56 UTC (permalink / raw) To: linux-usb, netdev From: Jan Dumon <j.dumon@option.com> Add Vendor/Product ID's for new devices. Signed-off-by: Jan Dumon <j.dumon@option.com> --- diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index fe98aca..d47c508 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = { {USB_DEVICE(0x0af0, 0x7701)}, {USB_DEVICE(0x0af0, 0x7801)}, {USB_DEVICE(0x0af0, 0x7901)}, - {USB_DEVICE(0x0af0, 0x7361)}, - {USB_DEVICE(0x0af0, 0xd057)}, + {USB_DEVICE(0x0af0, 0x8200)}, + {USB_DEVICE(0x0af0, 0x8201)}, + {USB_DEVICE(0x0af0, 0xd035)}, {USB_DEVICE(0x0af0, 0xd055)}, + {USB_DEVICE(0x0af0, 0xd155)}, + {USB_DEVICE(0x0af0, 0xd255)}, + {USB_DEVICE(0x0af0, 0xd057)}, + {USB_DEVICE(0x0af0, 0xd157)}, + {USB_DEVICE(0x0af0, 0xd257)}, + {USB_DEVICE(0x0af0, 0xd357)}, {} }; MODULE_DEVICE_TABLE(usb, hso_ids); ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] hso: add Vendor/Product ID's for new devices 2009-03-31 11:56 [PATCH] hso: add Vendor/Product ID's for new devices Jan Dumon @ 2009-04-01 7:33 ` Paulius Zaleckas [not found] ` <49D318E7.4050404-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org> 0 siblings, 1 reply; 9+ messages in thread From: Paulius Zaleckas @ 2009-04-01 7:33 UTC (permalink / raw) To: Jan Dumon; +Cc: linux-usb, netdev Jan Dumon wrote: > From: Jan Dumon <j.dumon@option.com> > > Add Vendor/Product ID's for new devices. > > Signed-off-by: Jan Dumon <j.dumon@option.com> > --- > diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c > index fe98aca..d47c508 100644 > --- a/drivers/net/usb/hso.c > +++ b/drivers/net/usb/hso.c > @@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = { > {USB_DEVICE(0x0af0, 0x7701)}, > {USB_DEVICE(0x0af0, 0x7801)}, > {USB_DEVICE(0x0af0, 0x7901)}, > - {USB_DEVICE(0x0af0, 0x7361)}, > - {USB_DEVICE(0x0af0, 0xd057)}, Please add comment in description why you are removing these IDs. > + {USB_DEVICE(0x0af0, 0x8200)}, > + {USB_DEVICE(0x0af0, 0x8201)}, > + {USB_DEVICE(0x0af0, 0xd035)}, > {USB_DEVICE(0x0af0, 0xd055)}, > + {USB_DEVICE(0x0af0, 0xd155)}, > + {USB_DEVICE(0x0af0, 0xd255)}, > + {USB_DEVICE(0x0af0, 0xd057)}, > + {USB_DEVICE(0x0af0, 0xd157)}, > + {USB_DEVICE(0x0af0, 0xd257)}, > + {USB_DEVICE(0x0af0, 0xd357)}, > {} > }; > MODULE_DEVICE_TABLE(usb, hso_ids); ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <49D318E7.4050404-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>]
* Re: [PATCH] hso: add Vendor/Product ID's for new devices [not found] ` <49D318E7.4050404-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org> @ 2009-04-01 7:44 ` Jan Dumon [not found] ` <49D31B43.20506-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org> 2009-04-01 8:07 ` David Miller 1 sibling, 1 reply; 9+ messages in thread From: Jan Dumon @ 2009-04-01 7:44 UTC (permalink / raw) To: Paulius Zaleckas Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA Paulius Zaleckas wrote: > Jan Dumon wrote: >> From: Jan Dumon <j.dumon-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org> >> >> Add Vendor/Product ID's for new devices. >> >> Signed-off-by: Jan Dumon <j.dumon-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org> >> --- >> diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c >> index fe98aca..d47c508 100644 >> --- a/drivers/net/usb/hso.c >> +++ b/drivers/net/usb/hso.c >> @@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = { >> {USB_DEVICE(0x0af0, 0x7701)}, >> {USB_DEVICE(0x0af0, 0x7801)}, >> {USB_DEVICE(0x0af0, 0x7901)}, >> - {USB_DEVICE(0x0af0, 0x7361)}, >> - {USB_DEVICE(0x0af0, 0xd057)}, > > Please add comment in description why you are removing these IDs. No ID's are removed. 0xd057 is added again by the same patch, 0x7361 was twice in the list. >> + {USB_DEVICE(0x0af0, 0x8200)}, >> + {USB_DEVICE(0x0af0, 0x8201)}, >> + {USB_DEVICE(0x0af0, 0xd035)}, >> {USB_DEVICE(0x0af0, 0xd055)}, >> + {USB_DEVICE(0x0af0, 0xd155)}, >> + {USB_DEVICE(0x0af0, 0xd255)}, >> + {USB_DEVICE(0x0af0, 0xd057)}, >> + {USB_DEVICE(0x0af0, 0xd157)}, >> + {USB_DEVICE(0x0af0, 0xd257)}, >> + {USB_DEVICE(0x0af0, 0xd357)}, >> {} >> }; >> MODULE_DEVICE_TABLE(usb, hso_ids); -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <49D31B43.20506-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>]
* Re: [PATCH] hso: add Vendor/Product ID's for new devices [not found] ` <49D31B43.20506-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org> @ 2009-04-01 8:43 ` Paulius Zaleckas 0 siblings, 0 replies; 9+ messages in thread From: Paulius Zaleckas @ 2009-04-01 8:43 UTC (permalink / raw) To: Jan Dumon; +Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA Jan Dumon wrote: > Paulius Zaleckas wrote: >> Jan Dumon wrote: >>> From: Jan Dumon <j.dumon-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org> >>> >>> Add Vendor/Product ID's for new devices. >>> >>> Signed-off-by: Jan Dumon <j.dumon-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org> >>> --- >>> diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c >>> index fe98aca..d47c508 100644 >>> --- a/drivers/net/usb/hso.c >>> +++ b/drivers/net/usb/hso.c >>> @@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = { >>> {USB_DEVICE(0x0af0, 0x7701)}, >>> {USB_DEVICE(0x0af0, 0x7801)}, >>> {USB_DEVICE(0x0af0, 0x7901)}, >>> - {USB_DEVICE(0x0af0, 0x7361)}, >>> - {USB_DEVICE(0x0af0, 0xd057)}, >> Please add comment in description why you are removing these IDs. > > No ID's are removed. > 0xd057 is added again by the same patch, 0x7361 was twice in the list. OK for 0xd057, but please add comment that you are removing duplicate definition of 0x7361. > >>> + {USB_DEVICE(0x0af0, 0x8200)}, >>> + {USB_DEVICE(0x0af0, 0x8201)}, >>> + {USB_DEVICE(0x0af0, 0xd035)}, >>> {USB_DEVICE(0x0af0, 0xd055)}, >>> + {USB_DEVICE(0x0af0, 0xd155)}, >>> + {USB_DEVICE(0x0af0, 0xd255)}, >>> + {USB_DEVICE(0x0af0, 0xd057)}, >>> + {USB_DEVICE(0x0af0, 0xd157)}, >>> + {USB_DEVICE(0x0af0, 0xd257)}, >>> + {USB_DEVICE(0x0af0, 0xd357)}, >>> {} >>> }; >>> MODULE_DEVICE_TABLE(usb, hso_ids); > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] hso: add Vendor/Product ID's for new devices [not found] ` <49D318E7.4050404-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org> 2009-04-01 7:44 ` Jan Dumon @ 2009-04-01 8:07 ` David Miller 1 sibling, 0 replies; 9+ messages in thread From: David Miller @ 2009-04-01 8:07 UTC (permalink / raw) To: paulius.zaleckas-Ft0m5Q12RQ9xBelEqimL3w Cc: j.dumon-x9gZzRpC1QbQT0dZR+AlfA, linux-usb-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA From: Paulius Zaleckas <paulius.zaleckas-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org> Date: Wed, 01 Apr 2009 10:33:59 +0300 > Jan Dumon wrote: > > @@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = { > > {USB_DEVICE(0x0af0, 0x7701)}, > > {USB_DEVICE(0x0af0, 0x7801)}, > > {USB_DEVICE(0x0af0, 0x7901)}, > > - {USB_DEVICE(0x0af0, 0x7361)}, > > - {USB_DEVICE(0x0af0, 0xd057)}, > > Please add comment in description why you are removing these IDs. This isn't the first time they've been asked to do this. -------------------- Subject: Re: [PATCH] hso: add new device id's From: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org> To: F.Aben-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org Cc: gregkh-l3A5Bk7waGM@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Date: Mon, 02 Feb 2009 16:33:00 -0800 (PST) X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) From: "Filip Aben" <F.Aben-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org> Date: Tue, 3 Feb 2009 01:26:14 +0100 > > -----Original Message----- > > From: David Miller [mailto:davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org] > > Sent: maandag 2 februari 2009 23:03 > > To: Filip Aben > > Cc: gregkh-l3A5Bk7waGM@public.gmane.org; netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > Subject: Re: [PATCH] hso: add new device id's > > > > Why won't 0xaf0/0xd051 ever be used? > > > > You should explain such things in your commit message, > > that way I don't have to ask. > > That ID was used in an internal engineering version of a device and > will never see commercial light. > Even if this ID will be 'recycled' in the future, which is very > unlikely, > I don't know what kind of device will be behind it. Therefore it's safer > to remove it. Great, please add that information to the commit message and resend your patch. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] hso: add Vendor/Product ID's for new devices @ 2009-04-01 8:57 Jan Dumon 2009-04-01 13:56 ` Alan Stern 2009-04-02 8:16 ` David Miller 0 siblings, 2 replies; 9+ messages in thread From: Jan Dumon @ 2009-04-01 8:57 UTC (permalink / raw) To: linux-usb, netdev; +Cc: Paulius Zaleckas, David Miller From: Jan Dumon <j.dumon@option.com> Add Vendor/Product ID's for new devices. Removed duplicate product ID 0x7361. Signed-off-by: Jan Dumon <j.dumon@option.com> --- diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c index fe98aca..d47c508 100644 --- a/drivers/net/usb/hso.c +++ b/drivers/net/usb/hso.c @@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = { {USB_DEVICE(0x0af0, 0x7701)}, {USB_DEVICE(0x0af0, 0x7801)}, {USB_DEVICE(0x0af0, 0x7901)}, - {USB_DEVICE(0x0af0, 0x7361)}, - {USB_DEVICE(0x0af0, 0xd057)}, + {USB_DEVICE(0x0af0, 0x8200)}, + {USB_DEVICE(0x0af0, 0x8201)}, + {USB_DEVICE(0x0af0, 0xd035)}, {USB_DEVICE(0x0af0, 0xd055)}, + {USB_DEVICE(0x0af0, 0xd155)}, + {USB_DEVICE(0x0af0, 0xd255)}, + {USB_DEVICE(0x0af0, 0xd057)}, + {USB_DEVICE(0x0af0, 0xd157)}, + {USB_DEVICE(0x0af0, 0xd257)}, + {USB_DEVICE(0x0af0, 0xd357)}, {} }; MODULE_DEVICE_TABLE(usb, hso_ids); ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] hso: add Vendor/Product ID's for new devices 2009-04-01 8:57 Jan Dumon @ 2009-04-01 13:56 ` Alan Stern [not found] ` <Pine.LNX.4.44L0.0904010954190.3360-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org> 2009-04-02 8:16 ` David Miller 1 sibling, 1 reply; 9+ messages in thread From: Alan Stern @ 2009-04-01 13:56 UTC (permalink / raw) To: Jan Dumon; +Cc: linux-usb, netdev, Paulius Zaleckas, David Miller On Wed, 1 Apr 2009, Jan Dumon wrote: > From: Jan Dumon <j.dumon@option.com> > > Add Vendor/Product ID's for new devices. > Removed duplicate product ID 0x7361. > > Signed-off-by: Jan Dumon <j.dumon@option.com> > --- > diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c > index fe98aca..d47c508 100644 > --- a/drivers/net/usb/hso.c > +++ b/drivers/net/usb/hso.c > @@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = { > {USB_DEVICE(0x0af0, 0x7701)}, > {USB_DEVICE(0x0af0, 0x7801)}, > {USB_DEVICE(0x0af0, 0x7901)}, > - {USB_DEVICE(0x0af0, 0x7361)}, > - {USB_DEVICE(0x0af0, 0xd057)}, > + {USB_DEVICE(0x0af0, 0x8200)}, > + {USB_DEVICE(0x0af0, 0x8201)}, > + {USB_DEVICE(0x0af0, 0xd035)}, > {USB_DEVICE(0x0af0, 0xd055)}, > + {USB_DEVICE(0x0af0, 0xd155)}, > + {USB_DEVICE(0x0af0, 0xd255)}, > + {USB_DEVICE(0x0af0, 0xd057)}, > + {USB_DEVICE(0x0af0, 0xd157)}, > + {USB_DEVICE(0x0af0, 0xd257)}, > + {USB_DEVICE(0x0af0, 0xd357)}, > {} > }; > MODULE_DEVICE_TABLE(usb, hso_ids); Is this list supposed to be kept in numerical order? The entries for 0xd057 and 0xd157 are in the wrong place. Alan Stern ^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <Pine.LNX.4.44L0.0904010954190.3360-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>]
* Re: [PATCH] hso: add Vendor/Product ID's for new devices [not found] ` <Pine.LNX.4.44L0.0904010954190.3360-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org> @ 2009-04-01 15:00 ` Jan Dumon 0 siblings, 0 replies; 9+ messages in thread From: Jan Dumon @ 2009-04-01 15:00 UTC (permalink / raw) To: Alan Stern Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA, netdev-u79uwXL29TY76Z2rM5mHXA, Paulius Zaleckas, David Miller Alan Stern wrote: > On Wed, 1 Apr 2009, Jan Dumon wrote: > >> From: Jan Dumon <j.dumon-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org> >> >> Add Vendor/Product ID's for new devices. >> Removed duplicate product ID 0x7361. >> >> Signed-off-by: Jan Dumon <j.dumon-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org> >> --- >> diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c >> index fe98aca..d47c508 100644 >> --- a/drivers/net/usb/hso.c >> +++ b/drivers/net/usb/hso.c >> @@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = { >> {USB_DEVICE(0x0af0, 0x7701)}, >> {USB_DEVICE(0x0af0, 0x7801)}, >> {USB_DEVICE(0x0af0, 0x7901)}, >> - {USB_DEVICE(0x0af0, 0x7361)}, >> - {USB_DEVICE(0x0af0, 0xd057)}, >> + {USB_DEVICE(0x0af0, 0x8200)}, >> + {USB_DEVICE(0x0af0, 0x8201)}, >> + {USB_DEVICE(0x0af0, 0xd035)}, >> {USB_DEVICE(0x0af0, 0xd055)}, >> + {USB_DEVICE(0x0af0, 0xd155)}, >> + {USB_DEVICE(0x0af0, 0xd255)}, >> + {USB_DEVICE(0x0af0, 0xd057)}, >> + {USB_DEVICE(0x0af0, 0xd157)}, >> + {USB_DEVICE(0x0af0, 0xd257)}, >> + {USB_DEVICE(0x0af0, 0xd357)}, >> {} >> }; >> MODULE_DEVICE_TABLE(usb, hso_ids); > > Is this list supposed to be kept in numerical order? The entries for > 0xd057 and 0xd157 are in the wrong place. We have an internal document with all the product ID's we use and I've followed that order. That way it's a lot easier for me to compare the two and spot the missing ID's every time the list gets updated. The devices with ID's 0x[0-2]55 are all from the same 'family' as are those with ID's 0x[0-3]57. That is why they are out of numerical order... Greets, Jan. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] hso: add Vendor/Product ID's for new devices 2009-04-01 8:57 Jan Dumon 2009-04-01 13:56 ` Alan Stern @ 2009-04-02 8:16 ` David Miller 1 sibling, 0 replies; 9+ messages in thread From: David Miller @ 2009-04-02 8:16 UTC (permalink / raw) To: j.dumon; +Cc: linux-usb, netdev, paulius.zaleckas From: Jan Dumon <j.dumon@option.com> Date: Wed, 1 Apr 2009 10:57:51 +0200 > Add Vendor/Product ID's for new devices. > Removed duplicate product ID 0x7361. > > Signed-off-by: Jan Dumon <j.dumon@option.com> Applied. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2009-04-02 8:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-03-31 11:56 [PATCH] hso: add Vendor/Product ID's for new devices Jan Dumon
2009-04-01 7:33 ` Paulius Zaleckas
[not found] ` <49D318E7.4050404-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2009-04-01 7:44 ` Jan Dumon
[not found] ` <49D31B43.20506-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
2009-04-01 8:43 ` Paulius Zaleckas
2009-04-01 8:07 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-04-01 8:57 Jan Dumon
2009-04-01 13:56 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.0904010954190.3360-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2009-04-01 15:00 ` Jan Dumon
2009-04-02 8:16 ` David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).