From: Paulius Zaleckas <paulius.zaleckas-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
To: Jan Dumon <j.dumon-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] hso: add Vendor/Product ID's for new devices
Date: Wed, 01 Apr 2009 11:43:58 +0300 [thread overview]
Message-ID: <49D3294E.10501@teltonika.lt> (raw)
In-Reply-To: <49D31B43.20506-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
Jan Dumon wrote:
> Paulius Zaleckas wrote:
>> Jan Dumon wrote:
>>> From: Jan Dumon <j.dumon-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
>>>
>>> Add Vendor/Product ID's for new devices.
>>>
>>> Signed-off-by: Jan Dumon <j.dumon-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
>>> ---
>>> diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
>>> index fe98aca..d47c508 100644
>>> --- a/drivers/net/usb/hso.c
>>> +++ b/drivers/net/usb/hso.c
>>> @@ -462,9 +462,16 @@ static const struct usb_device_id hso_ids[] = {
>>> {USB_DEVICE(0x0af0, 0x7701)},
>>> {USB_DEVICE(0x0af0, 0x7801)},
>>> {USB_DEVICE(0x0af0, 0x7901)},
>>> - {USB_DEVICE(0x0af0, 0x7361)},
>>> - {USB_DEVICE(0x0af0, 0xd057)},
>> Please add comment in description why you are removing these IDs.
>
> No ID's are removed.
> 0xd057 is added again by the same patch, 0x7361 was twice in the list.
OK for 0xd057, but please add comment that you are removing duplicate
definition of 0x7361.
>
>>> + {USB_DEVICE(0x0af0, 0x8200)},
>>> + {USB_DEVICE(0x0af0, 0x8201)},
>>> + {USB_DEVICE(0x0af0, 0xd035)},
>>> {USB_DEVICE(0x0af0, 0xd055)},
>>> + {USB_DEVICE(0x0af0, 0xd155)},
>>> + {USB_DEVICE(0x0af0, 0xd255)},
>>> + {USB_DEVICE(0x0af0, 0xd057)},
>>> + {USB_DEVICE(0x0af0, 0xd157)},
>>> + {USB_DEVICE(0x0af0, 0xd257)},
>>> + {USB_DEVICE(0x0af0, 0xd357)},
>>> {}
>>> };
>>> MODULE_DEVICE_TABLE(usb, hso_ids);
>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-04-01 8:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 11:56 [PATCH] hso: add Vendor/Product ID's for new devices Jan Dumon
2009-04-01 7:33 ` Paulius Zaleckas
[not found] ` <49D318E7.4050404-Ft0m5Q12RQ9xBelEqimL3w@public.gmane.org>
2009-04-01 7:44 ` Jan Dumon
[not found] ` <49D31B43.20506-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org>
2009-04-01 8:43 ` Paulius Zaleckas [this message]
2009-04-01 8:07 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-04-01 8:57 Jan Dumon
2009-04-01 13:56 ` Alan Stern
[not found] ` <Pine.LNX.4.44L0.0904010954190.3360-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org>
2009-04-01 15:00 ` Jan Dumon
2009-04-02 8:16 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49D3294E.10501@teltonika.lt \
--to=paulius.zaleckas-ft0m5q12rq9xbeleqiml3w@public.gmane.org \
--cc=j.dumon-x9gZzRpC1QbQT0dZR+AlfA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).