* [PATCH net next] myri10ge: fix compile error
@ 2009-04-17 17:14 Andrew Gallatin
2009-04-17 22:45 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Gallatin @ 2009-04-17 17:14 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Brice Goglin
[-- Attachment #1: Type: text/plain, Size: 296 bytes --]
A compilation error snuck into 2d90b0aa3bc484189940444bcddcbe0ebbb53af5
due to an over-zealous indent script removing spaces around array
initialization ellipsis. The attached patch fixes the myri10ge
compilation in net-next.
Thanks,
Drew
Signed-off-by: Andrew Gallatin <gallatin@myri.com>
[-- Attachment #2: fix_myri10ge_compile.diff --]
[-- Type: text/x-diff, Size: 610 bytes --]
diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
index 291944d..140794a 100644
--- a/drivers/net/myri10ge/myri10ge.c
+++ b/drivers/net/myri10ge/myri10ge.c
@@ -269,7 +269,7 @@ MODULE_PARM_DESC(myri10ge_fw_name, "Firmware image name");
#define MYRI10GE_MAX_BOARDS 8
static char *myri10ge_fw_names[MYRI10GE_MAX_BOARDS] =
- {[0...(MYRI10GE_MAX_BOARDS - 1)] = NULL };
+ {[0 ... (MYRI10GE_MAX_BOARDS - 1)] = NULL };
module_param_array_named(myri10ge_fw_names, myri10ge_fw_names, charp, NULL,
0444);
MODULE_PARM_DESC(myri10ge_fw_name, "Firmware image names per board");
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net next] myri10ge: fix compile error
2009-04-17 17:14 [PATCH net next] myri10ge: fix compile error Andrew Gallatin
@ 2009-04-17 22:45 ` David Miller
2009-04-18 10:37 ` Brice Goglin
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2009-04-17 22:45 UTC (permalink / raw)
To: gallatin; +Cc: netdev, brice
From: Andrew Gallatin <gallatin@myri.com>
Date: Fri, 17 Apr 2009 13:14:37 -0400
> A compilation error snuck into
> 2d90b0aa3bc484189940444bcddcbe0ebbb53af5
> due to an over-zealous indent script removing spaces around array
> initialization ellipsis. The attached patch fixes the myri10ge
> compilation in net-next.
>
> Signed-off-by: Andrew Gallatin <gallatin@myri.com>
It gives me great confidence in your work, seeing as you don't
even type 'make' on the patches you send me.
Sigh, applied...
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net next] myri10ge: fix compile error
2009-04-17 22:45 ` David Miller
@ 2009-04-18 10:37 ` Brice Goglin
0 siblings, 0 replies; 3+ messages in thread
From: Brice Goglin @ 2009-04-18 10:37 UTC (permalink / raw)
To: David Miller; +Cc: gallatin, netdev
David Miller wrote:
> From: Andrew Gallatin <gallatin@myri.com>
> Date: Fri, 17 Apr 2009 13:14:37 -0400
>
>
>> A compilation error snuck into
>> 2d90b0aa3bc484189940444bcddcbe0ebbb53af5
>> due to an over-zealous indent script removing spaces around array
>> initialization ellipsis. The attached patch fixes the myri10ge
>> compilation in net-next.
>>
>> Signed-off-by: Andrew Gallatin <gallatin@myri.com>
>>
>
> It gives me great confidence in your work, seeing as you don't
> even type 'make' on the patches you send me.
>
> Sigh, applied...
>
Apologies, it was entirely my fault here.
Brice
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-18 10:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-17 17:14 [PATCH net next] myri10ge: fix compile error Andrew Gallatin
2009-04-17 22:45 ` David Miller
2009-04-18 10:37 ` Brice Goglin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).