netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Dumazet <dada1@cosmosbay.com>
To: Tzungder Lin <tzungder@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: Probably a flaw in Linux rtl8139 driver FYI
Date: Sat, 18 Apr 2009 21:43:15 +0200	[thread overview]
Message-ID: <49EA2D53.3080504@cosmosbay.com> (raw)
In-Reply-To: <528f811a0904180828i6b414a10p2dda1a7cbb79db87@mail.gmail.com>

Tzungder Lin a écrit :
> Dear Eric,
> 
> I agree with you at first.
> But after I checked the driver code, I think tp->cur_rx has been set
> to zero in rtl8139_init_ring() which has been executed before
> rtl8139_hw_start().
> So, it should be safe already.
> Thanks for your advice still.
> FYR

Very good ! Could you formally post the patch with your Signoff,
and make it applicable with "patch -p1" ?

(Please read Documentation/SubmittingPatches if you need some info)

Thanks



  reply	other threads:[~2009-04-18 19:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <528f811a0904170008q34b5cde1l810fb22f78eefaf7@mail.gmail.com>
     [not found] ` <528f811a0904170010w2b2c8b34j698b255331f78765@mail.gmail.com>
2009-04-18 12:40   ` Probably a flaw in Linux rtl8139 driver FYI Tzungder Lin
2009-04-18 13:01     ` Eric Dumazet
2009-04-18 15:28       ` Tzungder Lin
2009-04-18 19:43         ` Eric Dumazet [this message]
2009-04-19  6:52           ` Tzungder Lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49EA2D53.3080504@cosmosbay.com \
    --to=dada1@cosmosbay.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=tzungder@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).