From: Ben Greear <greearb@candelatech.com>
To: Bob Copeland <me@bobcopeland.com>
Cc: NetDev <netdev@vger.kernel.org>
Subject: Re: ath5k irq warning message
Date: Thu, 23 Apr 2009 09:27:12 -0700 [thread overview]
Message-ID: <49F096E0.8030302@candelatech.com> (raw)
In-Reply-To: <20090423120638.GA3168@hash.localnet>
Bob Copeland wrote:
> On Wed, Apr 22, 2009 at 02:56:06PM -0700, Ben Greear wrote:
>> I notice this code in the ath5k_intr method.
>>
>> Won't counter be -1 if you break out of this due to the 'counter-- > 0'
>> clause?
>>
>> } while (ath5k_hw_is_intr_pending(ah) && counter-- > 0);
>
> Good catch, I guess it should be --counter...
That works for me.
Seems the root cause of my problem might have been fixed already
by the patch to turn off BMISS irqs, btw...about to start
testing that now.
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
prev parent reply other threads:[~2009-04-23 16:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 21:56 ath5k irq warning message Ben Greear
2009-04-23 12:06 ` Bob Copeland
2009-04-23 16:27 ` Ben Greear [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F096E0.8030302@candelatech.com \
--to=greearb@candelatech.com \
--cc=me@bobcopeland.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).