From: Geoff Levand <geoffrey.levand@am.sony.com>
To: linville@tuxdriver.com
Cc: jgarzik@pobox.com, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org,
Masakazu Mokuno <mokuno@sm.sony.co.jp>
Subject: [patch] net/ps3: Fix wireless AP connect error handling
Date: Thu, 23 Apr 2009 15:46:17 -0700 [thread overview]
Message-ID: <49F0EFB9.20709@am.sony.com> (raw)
In-Reply-To: <49D109B4.7020808@am.sony.com>
From: Masakazu Mokuno <mokuno@sm.sony.co.jp>
This patch fixes the bug that the driver tries to continue to
connect(associate) to AP even if gelic_wl_do_{wpa,wep}_setup() fails,
Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
Signed-off-by: Geoff Levand <geoffrey.levand@am.sony.com>
---
Hi John,
I didn't see this get merged in to 2.6.30 yet. Could you let me know the status?
-Geoff
drivers/net/ps3_gelic_wireless.c | 3 +++
1 file changed, 3 insertions(+)
--- a/drivers/net/ps3_gelic_wireless.c
+++ b/drivers/net/ps3_gelic_wireless.c
@@ -2101,6 +2101,9 @@ static int gelic_wl_associate_bss(struct
if (ret) {
pr_debug("%s: WEP/WPA setup failed %d\n", __func__,
ret);
+ ret = -EPERM;
+ gelic_wl_send_iwap_event(wl, NULL);
+ goto out;
}
/* start association */
next prev parent reply other threads:[~2009-04-23 22:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-30 18:04 [patch] net/ps3: Fix wireless AP connect error handling Geoff Levand
2009-04-23 22:46 ` Geoff Levand [this message]
2009-04-24 20:14 ` John W. Linville
[not found] ` <20090424201446.GD3309-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2009-04-24 20:58 ` Geoff Levand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49F0EFB9.20709@am.sony.com \
--to=geoffrey.levand@am.sony.com \
--cc=jgarzik@pobox.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mokuno@sm.sony.co.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).