netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Breno Leitao <leitao@linux.vnet.ibm.com>
To: e1000-devel@lists.sourceforge.net
Cc: netdev <netdev@vger.kernel.org>
Subject: [PATCH net-next] ixgbe: removing unnecesary assignments
Date: Wed, 29 Apr 2009 14:15:27 -0300	[thread overview]
Message-ID: <49F88B2F.4000802@linux.vnet.ibm.com> (raw)

This patch removes some assignment that are not necessary. Since the ret
variable is declared as false during its initialization, it makes no sense to
reassign false to it again.

Signed-off-by: Breno Leitao <leitao@linux.vnet.ibm.com>

---
 drivers/net/ixgbe/ixgbe_main.c |   12 ------------
 1 files changed, 0 insertions(+), 12 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 5020f11..c238677 100644
--- a/drivers/net/ixgbe/ixgbe_main.c
+++ b/drivers/net/ixgbe/ixgbe_main.c
@@ -2775,8 +2775,6 @@ static inline bool ixgbe_set_dcb_queues(struct ixgbe_adapter *adapter)
 		adapter->num_tx_queues =
 		                      adapter->ring_feature[RING_F_DCB].indices;
 		ret = true;
-	} else {
-		ret = false;
 	}
 
 	return ret;
@@ -2802,8 +2800,6 @@ static inline bool ixgbe_set_rss_queues(struct ixgbe_adapter *adapter)
 		adapter->num_tx_queues =
 		                      adapter->ring_feature[RING_F_RSS].indices;
 		ret = true;
-	} else {
-		ret = false;
 	}
 
 	return ret;
@@ -2910,8 +2906,6 @@ static inline bool ixgbe_cache_ring_rss(struct ixgbe_adapter *adapter)
 		for (i = 0; i < adapter->num_tx_queues; i++)
 			adapter->tx_ring[i].reg_idx = i;
 		ret = true;
-	} else {
-		ret = false;
 	}
 
 	return ret;
@@ -2986,14 +2980,8 @@ static inline bool ixgbe_cache_ring_dcb(struct ixgbe_adapter *adapter)
 					adapter->rx_ring[i].reg_idx = i << 5;
 
 				ret = true;
-			} else {
-				ret = false;
 			}
-		} else {
-			ret = false;
 		}
-	} else {
-		ret = false;
 	}
 
 	return ret;
-- 
1.6.0.2


------------------------------------------------------------------------------
Register Now & Save for Velocity, the Web Performance & Operations 
Conference from O'Reilly Media. Velocity features a full day of 
expert-led, hands-on workshops and two days of sessions from industry 
leaders in dedicated Performance & Operations tracks. Use code vel09scf 
and Save an extra 15% before 5/3. http://p.sf.net/sfu/velocityconf

             reply	other threads:[~2009-04-29 17:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-29 17:15 Breno Leitao [this message]
2009-04-29 22:27 ` [PATCH net-next] ixgbe: removing unnecesary assignments Jeff Kirsher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F88B2F.4000802@linux.vnet.ibm.com \
    --to=leitao@linux.vnet.ibm.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).