Re: [PATCH] fix build bug in 2.6.30-rc4: xt_socket.c:(.text+0x57780): undefined reference to `nf_conntrack_untracked'

[Laszlo Attila Toth <panther@balabit.hu>]

Hi,

Ingo is right, this patch is problematic because of the xt_socket code.
The nf_conntrack is not necessary for xt_socket, but it can use 
connection tracking.

The only problematic use case is what Ingo found:

  CONFIG_NF_CONNTRACK=m
  CONFIG_NETFILTER_XT_MATCH_SOCKET=y

The following patch solves it , I'll send it soon in a single letter:

diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
index 881203c..cb3ad74 100644
--- a/net/netfilter/Kconfig
+++ b/net/netfilter/Kconfig
@@ -837,6 +837,7 @@ config NETFILTER_XT_MATCH_SOCKET
         depends on NETFILTER_TPROXY
         depends on NETFILTER_XTABLES
         depends on NETFILTER_ADVANCED
+       depends on !NF_CONNTRACK || NF_CONNTRACK
         select NF_DEFRAG_IPV4
         help
           This option adds a `socket' match, which can be used to match


David Miller wrote:
> From: Ingo Molnar <mingo@elte.hu>
> Date: Thu, 30 Apr 2009 09:55:54 +0200
> 
>>     Revert "netfilter: Kconfig: TProxy doesn't depend on NF_CONNTRACK"
>>     
>>     This reverts commit 4b0706624930dc75c3b0d0df463d89759ef7de29.
> 
> Thanks Ingo, I'll apply this revert soon unless Patrick wants to
> handle it differently.
> 


-- 
Attila