netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: netdev@vger.kernel.org
Cc: Joao Pinto <Joao.Pinto@synopsys.com>,
	Jose Abreu <Jose.Abreu@synopsys.com>
Subject: [PATCH net-next 03/12] net: stmmac: xgmac: Correctly return that RX descriptor is not last one
Date: Fri,  9 Aug 2019 20:36:11 +0200	[thread overview]
Message-ID: <49ab9b51be8a73f89228b33f9f8d06a6ac553aa3.1565375521.git.joabreu@synopsys.com> (raw)
In-Reply-To: <cover.1565375521.git.joabreu@synopsys.com>
In-Reply-To: <cover.1565375521.git.joabreu@synopsys.com>

Return the correct value when RX descriptor is not the last one.

Signed-off-by: Jose Abreu <joabreu@synopsys.com>
---
 drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
index 2391ede97597..717b50d4aa93 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c
@@ -26,16 +26,15 @@ static int dwxgmac2_get_rx_status(void *data, struct stmmac_extra_stats *x,
 				  struct dma_desc *p)
 {
 	unsigned int rdes3 = le32_to_cpu(p->des3);
-	int ret = good_frame;
 
 	if (unlikely(rdes3 & XGMAC_RDES3_OWN))
 		return dma_own;
 	if (likely(!(rdes3 & XGMAC_RDES3_LD)))
+		return rx_not_ls;
+	if (unlikely((rdes3 & XGMAC_RDES3_ES) && (rdes3 & XGMAC_RDES3_LD)))
 		return discard_frame;
-	if (unlikely(rdes3 & XGMAC_RDES3_ES))
-		ret = discard_frame;
 
-	return ret;
+	return good_frame;
 }
 
 static int dwxgmac2_get_tx_len(struct dma_desc *p)
-- 
2.7.4


  parent reply	other threads:[~2019-08-09 18:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-09 18:36 [PATCH net-next 00/12] net: stmmac: Improvements for -next Jose Abreu
2019-08-09 18:36 ` [PATCH net-next 01/12] net: stmmac: Get correct timestamp values from XGMAC Jose Abreu
2019-08-09 19:43   ` David Miller
2019-08-09 18:36 ` [PATCH net-next 02/12] net: stmmac: Prepare to add Split Header support Jose Abreu
2019-08-09 18:36 ` Jose Abreu [this message]
2019-08-09 18:36 ` [PATCH net-next 04/12] net: stmmac: Add Split Header support and enable it in XGMAC cores Jose Abreu
2019-08-09 19:44   ` David Miller
2019-08-09 18:36 ` [PATCH net-next 05/12] net: stmmac: Add a counter for Split Header packets Jose Abreu
2019-08-09 18:36 ` [PATCH net-next 06/12] net: stmmac: dwxgmac: Add Flexible PPS support Jose Abreu
2019-08-09 18:36 ` [PATCH net-next 07/12] net: stmmac: Add ethtool register dump for XGMAC cores Jose Abreu
2019-08-09 18:36 ` [PATCH net-next 08/12] net: stmmac: Add support for SA Insertion/Replacement in " Jose Abreu
2019-08-09 18:36 ` [PATCH net-next 09/12] net: stmmac: selftests: Add tests for SA Insertion/Replacement Jose Abreu
2019-08-09 18:36 ` [PATCH net-next 10/12] net: stmmac: xgmac: Add EEE support Jose Abreu
2019-08-09 18:36 ` [PATCH net-next 11/12] net: stmmac: Add support for VLAN Insertion Offload Jose Abreu
2019-08-09 18:36 ` [PATCH net-next 12/12] net: stmmac: selftests: Add selftest for VLAN TX Offload Jose Abreu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49ab9b51be8a73f89228b33f9f8d06a6ac553aa3.1565375521.git.joabreu@synopsys.com \
    --to=jose.abreu@synopsys.com \
    --cc=Joao.Pinto@synopsys.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).