From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Subject: Re: [PATCH net] net: bridge: fix br_vlan_get_{pvid,info} return
 values
Date: Fri, 6 Jul 2018 15:51:28 +0300
Message-ID: <49b31434-53e5-72e9-ae0b-1c1200806a50@cumulusnetworks.com>
References: <20180706124420.3129099-1-arnd@arndb.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Jiri Pirko <jiri@mellanox.com>, Yotam Gigi <yotamg@mellanox.com>,
        Roopa Prabhu <roopa@cumulusnetworks.com>,
        Petr Machata <petrm@mellanox.com>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
To: Arnd Bergmann <arnd@arndb.de>,
        "David S. Miller" <davem@davemloft.net>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20180706124420.3129099-1-arnd@arndb.de>
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On 06/07/18 15:44, Arnd Bergmann wrote:
> These two functions return the regular -EINVAL failure in the normal
> code path, but return a nonstandard '-1' error otherwise, which gets
> interpreted as -EPERM.
> 
> Let's change it to -EINVAL for the dummy functions as well.
> 
> Fixes: 4d4fd36126d6 ("net: bridge: Publish bridge accessor functions")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  include/linux/if_bridge.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h
> index 7843b98e1c6e..c20c7e197d07 100644
> --- a/include/linux/if_bridge.h
> +++ b/include/linux/if_bridge.h
> @@ -105,13 +105,13 @@ static inline bool br_vlan_enabled(const struct net_device *dev)
>  
>  static inline int br_vlan_get_pvid(const struct net_device *dev, u16 *p_pvid)
>  {
> -	return -1;
> +	return -EINVAL;
>  }
>  
>  static inline int br_vlan_get_info(const struct net_device *dev, u16 vid,
>  				   struct bridge_vlan_info *p_vinfo)
>  {
> -	return -1;
> +	return -EINVAL;
>  }
>  #endif
>  
> 

Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>