From mboxrd@z Thu Jan 1 00:00:00 1970 From: prodyut hazarika Subject: Re: [PATCH 1/2] ibm_newemac: Add Support for MAL Interrupt Coalescing Date: Mon, 21 Sep 2009 17:28:35 -0700 Message-ID: <49c0ff980909211728s2d39e356p6900d047c6918826@mail.gmail.com> References: <1253573245-1867-1-git-send-email-phazarika@amcc.com> <1253576514.7103.165.camel@pasglop> <0CA0A16855646F4FA96D25A158E299D606FFE802@SDCEXCHANGE01.ad.amcc.com> <1253578361.7103.180.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Victor Gallardo , Feng Kan , netdev@vger.kernel.org, lada.podivin@gmail.com, Loc Ho , bhutchings@solarflare.com, Prodyut Hazarika , linuxppc-dev@lists.ozlabs.org, davem@davemloft.net To: Benjamin Herrenschmidt Return-path: In-Reply-To: <1253578361.7103.180.camel@pasglop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@lists.ozlabs.org List-Id: netdev.vger.kernel.org Hi Ben, > > BTW. If you guys are ever going to do another change to MAL, please > please plase, add the -one- major missing feature that's causing all the > pain and complication in the current design: Add a per-channel interrupt > masking option. > > The lack of ability to mask the interrupt per MAL channel is what forces > us to create that fake netdev structure in order to share the napi > device instance between all the EMACs in the system. This is very > inefficient too. We would be able to make things run a lot smoother if > we could just have a napi instance per EMAC, but for that, we need > per-channel interrupt masking. > I will add a patch for the above as soon as I am done incorporating your comments on the MAL coalescing support. Thanks Prodyut