From: Eric Dumazet <eric.dumazet@gmail.com>
To: Ioana Radulescu <ruxandra.radulescu@nxp.com>,
netdev@vger.kernel.org, davem@davemloft.net
Cc: ioana.ciornei@nxp.com, vladimir.oltean@nxp.com
Subject: Re: [PATCH net-next] dpaa2-eth: Don't use netif_receive_skb_list for TCP frames
Date: Wed, 24 Jul 2019 09:10:20 +0200 [thread overview]
Message-ID: <49d021a6-46de-f37e-8097-2836d0d31930@gmail.com> (raw)
In-Reply-To: <1563902923-26178-1-git-send-email-ruxandra.radulescu@nxp.com>
On 7/23/19 7:28 PM, Ioana Radulescu wrote:
> Using Rx skb bulking for all frames may negatively impact the
> performance in some TCP termination scenarios, as it effectively
> bypasses GRO.
>
> - list_add_tail(&skb->list, ch->rx_list);
> + if (frame_is_tcp(fd, fas))
> + napi_gro_receive(&ch->napi, skb);
> + else
> + list_add_tail(&skb->list, ch->rx_list);
>
> return;
>
This is really bad.
This is exactly why I suggested to add the batching capability to GRO,
instead having to change all drivers.
Edward Cree is working on this.
prev parent reply other threads:[~2019-07-24 7:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 17:28 [PATCH net-next] dpaa2-eth: Don't use netif_receive_skb_list for TCP frames Ioana Radulescu
2019-07-23 17:54 ` Saeed Mahameed
2019-07-23 21:02 ` David Miller
2019-07-24 8:15 ` Ioana Ciocoi Radulescu
2019-07-24 7:10 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49d021a6-46de-f37e-8097-2836d0d31930@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
--cc=ruxandra.radulescu@nxp.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox