public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Arvind Yadav <arvind.yadav.cs@gmail.com>
To: Joe Perches <joe@perches.com>, santosh@chelsio.com, davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: chelsio: cxgb3: constify attribute_group structures.
Date: Tue, 11 Jul 2017 11:23:38 +0530	[thread overview]
Message-ID: <49d4a885-5b27-35a5-be2d-08d5a483429b@gmail.com> (raw)
In-Reply-To: <1499752060.4457.8.camel@perches.com>

Hi Joe,


On Tuesday 11 July 2017 11:17 AM, Joe Perches wrote:
> On Tue, 2017-07-11 at 11:11 +0530, Arvind Yadav wrote:
>> Hi Joe,
>>
>>
>> On Monday 10 July 2017 10:30 PM, Joe Perches wrote:
>>> On Mon, 2017-07-10 at 16:04 +0530, Arvind Yadav wrote:
>>>> attribute_groups are not supposed to change at runtime. All functions
>>>> working with attribute_groups provided by <linux/sysfs.h> work
>>>> with const attribute_group. So mark the non-const structs as const.
>>> I think it's good you are doing all of these.
>>>
>>> Instead of individually sending these patches, could you
>>> please send a patch series for all of these attribute_group
>>> patches with a cover letter at the same time?
>>>
>>> That could make it easier for a trivial maintainer to apply
>>> all of these at once and not get some applied and others
>>> ignored or dropped on the floor.
>>>
>> Once again, I will send all of patch together, But I have doubt. If it's
>> having
>> different maintainer. Example- 'net:' subsystem is having a different
>> different
>> maintainer. So do i need to add all the maintainer in single list. Which
>> can confuse
>> what patch is for what maintainer. Please suggest me.
> Please send individual patches, one per maintainer/subsystem
> as a series with a cover letter like:
>
> 	[PATCH 0/N] treewide: constify attribute_group structures
> 	[PATCH 1/N] chelsio: cxgb3: constify attribute_group
> 	[PATCH 2/N] chelsio: cxgb4: constify attribute_group
> 	...
> 	[PATCH N/N] subsystem: constify attribute_group
>
Thank you, I will follow as per your suggestion.

Regards,
~arvind

      reply	other threads:[~2017-07-11  5:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10 10:34 [PATCH] net: chelsio: cxgb3: constify attribute_group structures Arvind Yadav
2017-07-10 17:00 ` Joe Perches
2017-07-11  5:41   ` Arvind Yadav
2017-07-11  5:47     ` Joe Perches
2017-07-11  5:53       ` Arvind Yadav [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49d4a885-5b27-35a5-be2d-08d5a483429b@gmail.com \
    --to=arvind.yadav.cs@gmail.com \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=santosh@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox