From: Victor Nogueira <victor@mojatatu.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dsahern@kernel.org, netdev@vger.kernel.org, kernel@mojatatu.com
Subject: Re: [PATCH iproute2-next] m_mirred: Allow mirred to block
Date: Tue, 23 Jan 2024 14:32:32 -0300 [thread overview]
Message-ID: <49ecd3a7-caf6-443c-9519-be300f8866ec@mojatatu.com> (raw)
In-Reply-To: <20240123091811.298e3cb5@hermes.local>
On 23/01/2024 14:18, Stephen Hemminger wrote:
> On Tue, 23 Jan 2024 13:11:15 -0300
> Victor Nogueira <victor@mojatatu.com> wrote:
>
>> + print_string(PRINT_ANY, "to_dev", " to device %s)", dev);
>
> Suggestion for future.
> Use colorized device name here.
> print_color_string(PRINT_ANY, COLOR_IFNAME, "to_dev", " to device %s)", dev);
Thank you for the suggestion.
Will send a patch after this one to fix this.
cheers,
Victor
next prev parent reply other threads:[~2024-01-23 17:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 16:11 [PATCH iproute2-next] m_mirred: Allow mirred to block Victor Nogueira
2024-01-23 17:18 ` Stephen Hemminger
2024-01-23 17:32 ` Victor Nogueira [this message]
2024-01-23 18:17 ` David Ahern
2024-01-23 21:41 ` Victor Nogueira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49ecd3a7-caf6-443c-9519-be300f8866ec@mojatatu.com \
--to=victor@mojatatu.com \
--cc=dsahern@kernel.org \
--cc=kernel@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox