From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jacky Chou <jacky_chou@aspeedtech.com>,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk
Subject: Re: [PATCH 1/2] dt-bindings: net: aspeed: Add binding for ASPEED AST2700 MDIO
Date: Thu, 5 Sep 2024 13:51:06 +0200 [thread overview]
Message-ID: <49eda495-fe7a-4f83-b9cc-03a04543005c@kernel.org> (raw)
In-Reply-To: <20240905114754.519609-2-jacky_chou@aspeedtech.com>
On 05/09/2024 13:47, Jacky Chou wrote:
> Add a new compatible for ASPEED AST2700 MDIO.
>
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
A nit, subject: drop second/last, redundant "binding for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-09-05 11:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 11:47 [PATCH 0/2] net: mdio: Add ASPEED AST2700 MDIO compatible Jacky Chou
2024-09-05 11:47 ` [PATCH 1/2] dt-bindings: net: aspeed: Add binding for ASPEED AST2700 MDIO Jacky Chou
2024-09-05 11:49 ` Krzysztof Kozlowski
2024-09-05 11:51 ` Krzysztof Kozlowski [this message]
2024-09-05 11:47 ` [PATCH 2/2] net: mdio: aspeed: Add AST2700 support Jacky Chou
2024-09-05 11:50 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49eda495-fe7a-4f83-b9cc-03a04543005c@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jacky_chou@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).