[PATCH 0/2] net: mdio: Add ASPEED AST2700 MDIO compatible

[PATCH 0/2] net: mdio: Add ASPEED AST2700 MDIO compatible

[Jacky Chou]

Add a new compatible to dt-binding and mdio driver for ASPEED
AST2700 MDIO.

Jacky Chou (2):
  dt-bindings: net: aspeed: Add binding for ASPEED AST2700 MDIO
  net: mdio: aspeed: Add AST2700 support

 .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml          | 4 +++-
 drivers/net/mdio/mdio-aspeed.c                                | 1 +
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
2.25.1

[PATCH 1/2] dt-bindings: net: aspeed: Add binding for ASPEED AST2700 MDIO

[Jacky Chou]

Add a new compatible for ASPEED AST2700 MDIO.

Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
---
 .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml          | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
index d6ef468495c5..6dadca099875 100644
--- a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
@@ -19,7 +19,9 @@ allOf:
 
 properties:
   compatible:
-    const: aspeed,ast2600-mdio
+    enum:
+      - aspeed,ast2600-mdio
+      - aspeed,ast2700-mdio
 
   reg:
     maxItems: 1
-- 
2.25.1

[PATCH 2/2] net: mdio: aspeed: Add AST2700 support

[Jacky Chou]

Add AST2700 compatible for Aspeed MDIO driver.

Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
---
 drivers/net/mdio/mdio-aspeed.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mdio/mdio-aspeed.c b/drivers/net/mdio/mdio-aspeed.c
index c2170650415c..607e5c56434f 100644
--- a/drivers/net/mdio/mdio-aspeed.c
+++ b/drivers/net/mdio/mdio-aspeed.c
@@ -188,6 +188,7 @@ static void aspeed_mdio_remove(struct platform_device *pdev)
 
 static const struct of_device_id aspeed_mdio_of_match[] = {
 	{ .compatible = "aspeed,ast2600-mdio", },
+	{ .compatible = "aspeed,ast2700-mdio", },
 	{ },
 };
 MODULE_DEVICE_TABLE(of, aspeed_mdio_of_match);
-- 
2.25.1

Re: [PATCH 1/2] dt-bindings: net: aspeed: Add binding for ASPEED AST2700 MDIO

[Krzysztof Kozlowski]

On 05/09/2024 13:47, Jacky Chou wrote:
> Add a new compatible for ASPEED AST2700 MDIO.

You have entire commit msg to explain the differences of the hardware,
including whether they are or are not compatible.

> 
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> ---
>  .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml          | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> index d6ef468495c5..6dadca099875 100644
> --- a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml
> @@ -19,7 +19,9 @@ allOf:
>  
>  properties:
>    compatible:
> -    const: aspeed,ast2600-mdio
> +    enum:
> +      - aspeed,ast2600-mdio
> +      - aspeed,ast2700-mdio

Your driver says something else...

Best regards,
Krzysztof

Re: [PATCH 2/2] net: mdio: aspeed: Add AST2700 support

[Krzysztof Kozlowski]

On 05/09/2024 13:47, Jacky Chou wrote:
> Add AST2700 compatible for Aspeed MDIO driver.
> 
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> ---
>  drivers/net/mdio/mdio-aspeed.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/mdio/mdio-aspeed.c b/drivers/net/mdio/mdio-aspeed.c
> index c2170650415c..607e5c56434f 100644
> --- a/drivers/net/mdio/mdio-aspeed.c
> +++ b/drivers/net/mdio/mdio-aspeed.c
> @@ -188,6 +188,7 @@ static void aspeed_mdio_remove(struct platform_device *pdev)
>  
>  static const struct of_device_id aspeed_mdio_of_match[] = {
>  	{ .compatible = "aspeed,ast2600-mdio", },
> +	{ .compatible = "aspeed,ast2700-mdio", },

Why? They are compatible, aren't they? Write useful commit msgs so you
won't get simple questions on each review.

Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: net: aspeed: Add binding for ASPEED AST2700 MDIO

[Krzysztof Kozlowski]

On 05/09/2024 13:47, Jacky Chou wrote:
> Add a new compatible for ASPEED AST2700 MDIO.
> 
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>

A nit, subject: drop second/last, redundant "binding for". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18

Best regards,
Krzysztof