From: Matt Johnston <matt@codeconstruct.com.au>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Zev Weiss <zev@bewilderbeest.net>, Wolfram Sang <wsa@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Brendan Higgins <brendanhiggins@google.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
Avi Fishman <avifishman70@gmail.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Tali Perry <tali.perry1@gmail.com>,
Patrick Venture <venture@google.com>,
Nancy Yuen <yuenn@google.com>,
Benjamin Fair <benjaminfair@google.com>,
Jeremy Kerr <jk@codeconstruct.com.au>,
linux-i2c@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 6/6] mctp i2c: MCTP I2C binding driver
Date: Tue, 02 Nov 2021 14:48:41 +0800 [thread overview]
Message-ID: <49f5ecb1ab4ba4b28c875ec1d40aa57991907b0f.camel@codeconstruct.com.au> (raw)
In-Reply-To: <5650511d-f6aa-97a4-ce82-060c2c51afb5@infradead.org>
Hi Randy,
> > +config MCTP_TRANSPORT_I2C
> > + tristate "MCTP SMBus/I2C transport"
> > + # i2c-mux is optional, but we must build as a module if i2c-mux is a module
> > + depends on !I2C_MUX || I2C_MUX=y || m
>
> I'm fairly sure that the ending "m" there forces this to always be built
> as a loadable module. Is that what you meant to do here?
>
> Maybe you want something like this?
>
> depends on I2C_MUX || !I2C_MUX
Checking here it behaves as intended, this gives mctp-i2c built-in:
CONFIG_I2C_MUX=y
CONFIG_MCTP_TRANSPORT_I2C=y
Setting CONFIG_I2C_MUX=m forces CONFIG_MCTP_TRANSPORT_I2C=m.
Though I will change it to your suggestion since that's more concise.
Cheers,
Matt
prev parent reply other threads:[~2021-11-02 6:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-01 9:03 [PATCH net-next 0/6] MCTP I2C driver Matt Johnston
2021-11-01 9:04 ` [PATCH net-next 1/6] i2c: core: Allow 255 byte transfers for SMBus 3.x Matt Johnston
2021-11-01 9:04 ` [PATCH net-next 2/6] i2c: dev: Handle 255 byte blocks for i2c ioctl Matt Johnston
2021-11-01 9:04 ` [PATCH net-next 3/6] i2c: aspeed: Allow 255 byte block transfers Matt Johnston
2021-11-01 9:04 ` [PATCH net-next 4/6] i2c: npcm7xx: Allow 255 byte block SMBus transfers Matt Johnston
2021-11-01 9:04 ` [PATCH net-next 5/6] dt-bindings: net: New binding mctp-i2c-controller Matt Johnston
2021-11-01 9:04 ` [PATCH net-next 6/6] mctp i2c: MCTP I2C binding driver Matt Johnston
2021-11-01 13:22 ` Randy Dunlap
2021-11-02 6:48 ` Matt Johnston [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49f5ecb1ab4ba4b28c875ec1d40aa57991907b0f.camel@codeconstruct.com.au \
--to=matt@codeconstruct.com.au \
--cc=andrew@aj.id.au \
--cc=avifishman70@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=benjaminfair@google.com \
--cc=brendanhiggins@google.com \
--cc=davem@davemloft.net \
--cc=jk@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=kuba@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=wsa@kernel.org \
--cc=yuenn@google.com \
--cc=zev@bewilderbeest.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).