From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: fubar@us.ibm.com, greearb@candelatech.com, netdev@vger.kernel.org
Subject: Re: vlan: update vlan carrier state for admin up/down
Date: Tue, 05 May 2009 14:41:08 +0200 [thread overview]
Message-ID: <4A0033E4.2070802@trash.net> (raw)
In-Reply-To: <20090427.183640.182469000.davem@davemloft.net>
David Miller wrote:
> From: Jay Vosburgh <fubar@us.ibm.com>
> Date: Mon, 27 Apr 2009 16:55:58 -0700
>
>> I'm reluctant to mess with this behavior without knowing why it
>> works this way; there may be a good reason for it that I'm not aware
>> of.
>
> To be honest I think it's just that this is one huge dark
> corner of behavior for many virtual devices, rather than
> any of it being intentional.
Indeed. In case of VLANs it has always been this way and I'm
reluctant to change the default behaviour since people might
be relying on this to flush their routes or something similar.
For new drivers I'd say they should always use operstate. For
VLAN the safest way would be to add a flag to disable this
behaviour.
next prev parent reply other threads:[~2009-05-05 12:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-24 15:44 vlan: update vlan carrier state for admin up/down Patrick McHardy
2009-04-24 16:39 ` Ben Greear
2009-04-25 0:31 ` Jay Vosburgh
2009-04-26 19:58 ` Ben Greear
2009-04-27 23:55 ` Jay Vosburgh
2009-04-28 1:36 ` David Miller
2009-04-30 7:48 ` Ben Greear
2009-05-05 12:41 ` Patrick McHardy [this message]
2009-04-26 1:06 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A0033E4.2070802@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=greearb@candelatech.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).