Re: [RFC] iproute2/tc caching proposal

[Jarek Poplawski <jarkao2@gmail.com>]

Denys Fedoryschenko wrote, On 05/07/2009 12:03 AM:

> Since already someone did caching in iproute2, my changes is very trivial, but 
> giving huge improvement in batch performance (30k rules 10minutes vs 30 
> seconds).
> 
> ll_init_map is called in many places in tc, but since tc not changing 
> anything, that can change this map, i think it is enough to call it only at 
> the beginning, after rtnl_open().
> 
> Only one exclusion - tc monitor, because it is running long time, and things 
> can change over this time, so we call ll_init_map on each received rtnetlink 
> event.


Do you mean 30 sec. is to short for a change? I don't know these things enough;
your idea looks very nice, but I wonder if you tested how it behaves if e.g.
after 15k rules some dev goes away which is used in the next 15k?

> 
> Also please check "[RFC] [IPROUTE2] Filter class output by classid", if it is 
> ok. Many people told it is useful patch.
> 


I agree it's useful and quite natural option.

Thanks,
Jarek P.