* [PATCH] Neterion: *FIFO1_DMA_ERR set twice, should 2nd be *FIFO2_DMA_ERR?
@ 2009-05-15 20:19 Roel Kluin
2009-05-17 7:52 ` Ramkrishna Vepa
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2009-05-15 20:19 UTC (permalink / raw)
To: ram.vepa; +Cc: netdev, Andrew Morton
FIFO1_DMA_ERR is set twice, the second should be FIFO2_DMA_ERR.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Correct? Please review.
diff --git a/drivers/net/vxge/vxge-traffic.c b/drivers/net/vxge/vxge-traffic.c
index 7be0ae1..c2eeac4 100644
--- a/drivers/net/vxge/vxge-traffic.c
+++ b/drivers/net/vxge/vxge-traffic.c
@@ -115,7 +115,7 @@ enum vxge_hw_status vxge_hw_vpath_intr_enable(struct __vxge_hw_vpath_handle *vp)
VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_POISON|
VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO2_POISON|
VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_DMA_ERR|
- VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_DMA_ERR), 0, 32),
+ VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO2_DMA_ERR), 0, 32),
&vp_reg->kdfcctl_errors_mask);
__vxge_hw_pio_mem_write32_upper(0, &vp_reg->vpath_ppif_int_mask);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] Neterion: *FIFO1_DMA_ERR set twice, should 2nd be *FIFO2_DMA_ERR?
2009-05-15 20:19 [PATCH] Neterion: *FIFO1_DMA_ERR set twice, should 2nd be *FIFO2_DMA_ERR? Roel Kluin
@ 2009-05-17 7:52 ` Ramkrishna Vepa
2009-05-18 4:18 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Ramkrishna Vepa @ 2009-05-17 7:52 UTC (permalink / raw)
To: Roel Kluin; +Cc: netdev, Andrew Morton
> FIFO1_DMA_ERR is set twice, the second should be FIFO2_DMA_ERR.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Correct? Please review.
>
> diff --git a/drivers/net/vxge/vxge-traffic.c b/drivers/net/vxge/vxge-
> traffic.c
> index 7be0ae1..c2eeac4 100644
> --- a/drivers/net/vxge/vxge-traffic.c
> +++ b/drivers/net/vxge/vxge-traffic.c
> @@ -115,7 +115,7 @@ enum vxge_hw_status
vxge_hw_vpath_intr_enable(struct
> __vxge_hw_vpath_handle *vp)
> VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_POISON|
> VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO2_POISON|
> VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_DMA_ERR|
> - VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO1_DMA_ERR), 0,
32),
> + VXGE_HW_KDFCCTL_ERRORS_REG_KDFCCTL_FIFO2_DMA_ERR), 0,
32),
> &vp_reg->kdfcctl_errors_mask);
>
> __vxge_hw_pio_mem_write32_upper(0,
&vp_reg->vpath_ppif_int_mask);
[Ram] Good catch!
Acked-by: Ram Vepa <ram.vepa@neterion.com>
Thanks,
Ram
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Neterion: *FIFO1_DMA_ERR set twice, should 2nd be *FIFO2_DMA_ERR?
2009-05-17 7:52 ` Ramkrishna Vepa
@ 2009-05-18 4:18 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-05-18 4:18 UTC (permalink / raw)
To: Ramkrishna.Vepa; +Cc: roel.kluin, netdev, akpm
From: "Ramkrishna Vepa" <Ramkrishna.Vepa@neterion.com>
Date: Sun, 17 May 2009 03:52:59 -0400
>> FIFO1_DMA_ERR is set twice, the second should be FIFO2_DMA_ERR.
>>
>> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
...
> Acked-by: Ram Vepa <ram.vepa@neterion.com>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-05-18 4:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-15 20:19 [PATCH] Neterion: *FIFO1_DMA_ERR set twice, should 2nd be *FIFO2_DMA_ERR? Roel Kluin
2009-05-17 7:52 ` Ramkrishna Vepa
2009-05-18 4:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).