* [patch next 1/2] netxen: fix msi irq setup
@ 2009-05-14 7:16 Dhananjay Phadke
2009-05-19 4:47 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Dhananjay Phadke @ 2009-05-14 7:16 UTC (permalink / raw)
To: davem; +Cc: netdev
The pdev->irq was not saved in netxen_adapter, causing request_irq()
with invalid irq number.
This was broken in commit be339aee634d5cb98a8df8d6febe04002ec497f3.
Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>
---
drivers/net/netxen/netxen_nic_main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/netxen/netxen_nic_main.c b/drivers/net/netxen/netxen_nic_main.c
index 86ca081..50477f5 100644
--- a/drivers/net/netxen/netxen_nic_main.c
+++ b/drivers/net/netxen/netxen_nic_main.c
@@ -539,6 +539,7 @@ netxen_setup_intr(struct netxen_adapter *adapter)
adapter->msi_tgt_status =
msi_tgt_status[adapter->ahw.pci_func];
dev_info(&pdev->dev, "using msi interrupts\n");
+ adapter->msix_entries[0].vector = pdev->irq;
return;
}
--
1.6.0.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch next 1/2] netxen: fix msi irq setup
2009-05-14 7:16 [patch next 1/2] netxen: fix msi irq setup Dhananjay Phadke
@ 2009-05-19 4:47 ` David Miller
2009-05-19 18:29 ` Dhananjay Phadke
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2009-05-19 4:47 UTC (permalink / raw)
To: dhananjay; +Cc: netdev
From: Dhananjay Phadke <dhananjay@netxen.com>
Date: Thu, 14 May 2009 00:16:08 -0700
> The pdev->irq was not saved in netxen_adapter, causing request_irq()
> with invalid irq number.
>
> This was broken in commit be339aee634d5cb98a8df8d6febe04002ec497f3.
>
> Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>
Applied, but please reference commits also by header line
text. See below for the actual commit message I used so
you can see how it should be done, thanks!
netxen: fix msi irq setup
The pdev->irq was not saved in netxen_adapter, causing request_irq()
with invalid irq number.
This was broken in commit be339aee634d5cb98a8df8d6febe04002ec497f3
("netxen: fix irq tear down and msix leak.").
Signed-off-by: Dhananjay Phadke <dhananjay@netxen.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-05-19 18:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-14 7:16 [patch next 1/2] netxen: fix msi irq setup Dhananjay Phadke
2009-05-19 4:47 ` David Miller
2009-05-19 18:29 ` Dhananjay Phadke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).