From: "Hong H. Pham" <hong.pham@windriver.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, matheos.worku@sun.com
Subject: Re: [PATCH 0/1] NIU: fix spurious interrupts
Date: Tue, 19 May 2009 17:52:15 -0400 [thread overview]
Message-ID: <4A132A0F.8070800@windriver.com> (raw)
In-Reply-To: <20090518.220911.102225532.davem@davemloft.net>
David Miller wrote:
> Thanks for tracking down this problem, but I want to understand
> why this even happens. As far as I can tell it shouldn't.
>
> When we are done polling, the order of events is:
>
> 1) unmask LDG interrupt(s)
> 2) napi_complete()
> 3) rearm LDG interrupt(s)
>
> The interrupts should not be sent again until that rearm operation,
> which is after NAPI is completed. So the condition you are hitting
> does not seem possible.
My thoughts exactly... this should not happen.
> Matheos, can the chip violate this? If an RX event is reported
> in an LDG, it is masked, and then unmaked the interrupt should
> not appear until the LDG is also rearmed right?
Unfortunately I don't have a PCIe NIU card to test in an x86 box. If
the hang does not happen on x86 (which is my suspicion), that would rule
out a problem with the NIU chip. That would mean there's some
interaction between the NIU and sun4v hypervisor that's causing the
spurious interrupts.
Hong
next prev parent reply other threads:[~2009-05-19 21:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-11 19:00 [PATCH 0/1] NIU: fix spurious interrupts Hong H. Pham
2009-05-11 19:00 ` [PATCH 1/1] " Hong H. Pham
2009-05-19 5:09 ` [PATCH 0/1] " David Miller
2009-05-19 21:52 ` Hong H. Pham [this message]
2009-05-19 22:01 ` David Miller
2009-05-20 15:57 ` Hong H. Pham
2009-05-21 0:37 ` David Miller
2009-05-21 22:18 ` David Miller
2009-05-22 0:40 ` Hong H. Pham
2009-05-22 8:08 ` David Miller
2009-05-22 16:42 ` Hong H. Pham
2009-05-26 6:16 ` David Miller
2009-05-27 16:29 ` Hong H. Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A132A0F.8070800@windriver.com \
--to=hong.pham@windriver.com \
--cc=davem@davemloft.net \
--cc=matheos.worku@sun.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).