From: Mike Christie <michaelc@cs.wisc.edu>
To: open-iscsi@googlegroups.com
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"James.Bottomley@HansenPartnership.com"
<James.Bottomley@HansenPartnership.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Karen Xie <kxie@chelsio.com>,
Anil Veerabhadrappa <anilgv@broadcom.com>,
Benjamin Li <benli@broadcom.com>
Subject: Re: [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver.
Date: Wed, 20 May 2009 14:57:03 -0500 [thread overview]
Message-ID: <4A14608F.6070800@cs.wisc.edu> (raw)
In-Reply-To: <1242838735.10180.228.camel@HP1>
Michael Chan wrote:
> diff --git a/include/scsi/iscsi_if.h b/include/scsi/iscsi_if.h
> index 2c1a4af..0990dbb 100644
> --- a/include/scsi/iscsi_if.h
> +++ b/include/scsi/iscsi_if.h
> @@ -23,6 +23,9 @@
>
> + */
> +struct iscsi_path {
> + uint64_t handle;
> + uint8_t mac_addr[6];
> + uint8_t mac_addr_old[6];
> + uint32_t ip_addr_len; /* 4 or 16 */
> + union {
> + struct in_addr v4_addr;
> + struct in6_addr v6_addr;
> + } src;
> + union {
> + struct in_addr v4_addr;
> + struct in6_addr v6_addr;
I think we have to include in6.h and in.h in this file, right? iser
would not compile with this patch without it. If that is right and it
works for you now, I can just fix it when I merge the patch.
next prev parent reply other threads:[~2009-05-20 19:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-01 20:00 [PATCH 0/4] Add bnx2 iscsi support Michael Chan
2009-05-01 20:00 ` [PATCH 1/4] bnx2: Add support for CNIC driver Michael Chan
[not found] ` <1241208039-6813-1-git-send-email-mchan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2009-05-01 20:00 ` [PATCH 2/4] cnic: Add new " Michael Chan
2009-05-01 20:00 ` [PATCH 3/4] iscsi class, libiscsi: Add net config Michael Chan
[not found] ` <1241208039-6813-4-git-send-email-mchan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2009-05-06 16:40 ` Mike Christie
2009-05-06 16:42 ` Michael Chan
2009-06-08 17:56 ` James Bottomley
2009-06-08 17:59 ` Michael Chan
2009-06-08 18:13 ` James Bottomley
2009-06-08 18:07 ` Mike Christie
[not found] ` <4A2D5374.3030503-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
2009-06-08 20:07 ` Hans de Goede
2009-06-08 20:06 ` Michael Chan
2009-06-08 20:24 ` Mike Christie
2009-06-08 20:27 ` Hans de Goede
2009-05-01 20:00 ` [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver Michael Chan
2009-05-06 16:48 ` Mike Christie
2009-05-06 23:02 ` Karen Xie
2009-05-07 17:03 ` Michael Chan
2009-05-07 21:01 ` Mike Christie
2009-05-19 1:50 ` Michael Chan
2009-05-19 14:22 ` Mike Christie
2009-05-19 20:47 ` Michael Chan
2009-05-19 21:58 ` Mike Christie
2009-05-20 16:58 ` Michael Chan
2009-05-20 19:57 ` Mike Christie [this message]
[not found] ` <4A14608F.6070800-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org>
2009-05-20 22:22 ` Michael Chan
2009-05-20 22:51 ` Mike Christie
-- strict thread matches above, loose matches on Subject: below --
2009-06-09 1:14 [PATCH 0/4] Add Broadcom " Michael Chan
[not found] ` <1244510084-4457-1-git-send-email-mchan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2009-06-09 1:14 ` [PATCH 4/4] bnx2i: Add " Michael Chan
2009-04-24 0:22 [PATCH 0/4] Add bnx2 iSCSI support Michael Chan
[not found] ` <1240532563-23048-1-git-send-email-mchan-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2009-04-24 0:22 ` [PATCH 4/4] bnx2i: Add bnx2i iSCSI driver Michael Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A14608F.6070800@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@HansenPartnership.com \
--cc=anilgv@broadcom.com \
--cc=benli@broadcom.com \
--cc=davem@davemloft.net \
--cc=kxie@chelsio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=open-iscsi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).