From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Kluin Subject: [PATCH] sunlance: beyond ARRAY_SIZE of ib->btx_ring Date: Thu, 21 May 2009 22:31:12 +0200 Message-ID: <4A15BA10.7080605@gmail.com> References: <4A15B95D.4050200@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Andrew Morton , netdev@vger.kernel.org To: Jeff Garzik Return-path: Received: from mail-ew0-f176.google.com ([209.85.219.176]:55679 "EHLO mail-ew0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753465AbZEUUbM (ORCPT ); Thu, 21 May 2009 16:31:12 -0400 Received: by ewy24 with SMTP id 24so1469354ewy.37 for ; Thu, 21 May 2009 13:31:12 -0700 (PDT) In-Reply-To: <4A15B95D.4050200@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Do not go beyond ARRAY_SIZE of ib->btx_ring Signed-off-by: Roel Kluin --- Please ignore the other "X: ... patch" diff --git a/drivers/net/sunlance.c b/drivers/net/sunlance.c index 704301a..e7f1178 100644 --- a/drivers/net/sunlance.c +++ b/drivers/net/sunlance.c @@ -343,7 +343,7 @@ static void lance_init_ring_dvma(struct net_device *dev) ib->phys_addr [5] = dev->dev_addr [4]; /* Setup the Tx ring entries */ - for (i = 0; i <= TX_RING_SIZE; i++) { + for (i = 0; i < TX_RING_SIZE; i++) { leptr = LANCE_ADDR(aib + libbuff_offset(tx_buf, i)); ib->btx_ring [i].tmd0 = leptr; ib->btx_ring [i].tmd1_hadr = leptr >> 16; @@ -399,7 +399,7 @@ static void lance_init_ring_pio(struct net_device *dev) sbus_writeb(dev->dev_addr[4], &ib->phys_addr[5]); /* Setup the Tx ring entries */ - for (i = 0; i <= TX_RING_SIZE; i++) { + for (i = 0; i < TX_RING_SIZE; i++) { leptr = libbuff_offset(tx_buf, i); sbus_writew(leptr, &ib->btx_ring [i].tmd0); sbus_writeb(leptr >> 16,&ib->btx_ring [i].tmd1_hadr);