* [PATCH] X:beyond ARRAY_SIZE of ib->btx_ring
@ 2009-05-21 20:28 Roel Kluin
2009-05-21 20:31 ` [PATCH] sunlance: beyond " Roel Kluin
0 siblings, 1 reply; 4+ messages in thread
From: Roel Kluin @ 2009-05-21 20:28 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Andrew Morton, netdev
Do not go beyond ARRAY_SIZE of ib->btx_ring
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/net/sunlance.c b/drivers/net/sunlance.c
index 704301a..aa2a4ef 100644
--- a/drivers/net/sunlance.c
+++ b/drivers/net/sunlance.c
@@ -343,7 +343,7 @@ static void lance_init_ring_dvma(struct net_device *dev)
ib->phys_addr [5] = dev->dev_addr [4];
/* Setup the Tx ring entries */
- for (i = 0; i <= TX_RING_SIZE; i++) {
+ for (i = 0; i < TX_RING_SIZE; i++) {
leptr = LANCE_ADDR(aib + libbuff_offset(tx_buf, i));
ib->btx_ring [i].tmd0 = leptr;
ib->btx_ring [i].tmd1_hadr = leptr >> 16;
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] sunlance: beyond ARRAY_SIZE of ib->btx_ring
2009-05-21 20:28 [PATCH] X:beyond ARRAY_SIZE of ib->btx_ring Roel Kluin
@ 2009-05-21 20:31 ` Roel Kluin
2009-05-21 20:34 ` David Miller
2009-05-21 22:02 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Roel Kluin @ 2009-05-21 20:31 UTC (permalink / raw)
To: Jeff Garzik; +Cc: Andrew Morton, netdev
Do not go beyond ARRAY_SIZE of ib->btx_ring
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Please ignore the other "X: ... patch"
diff --git a/drivers/net/sunlance.c b/drivers/net/sunlance.c
index 704301a..e7f1178 100644
--- a/drivers/net/sunlance.c
+++ b/drivers/net/sunlance.c
@@ -343,7 +343,7 @@ static void lance_init_ring_dvma(struct net_device *dev)
ib->phys_addr [5] = dev->dev_addr [4];
/* Setup the Tx ring entries */
- for (i = 0; i <= TX_RING_SIZE; i++) {
+ for (i = 0; i < TX_RING_SIZE; i++) {
leptr = LANCE_ADDR(aib + libbuff_offset(tx_buf, i));
ib->btx_ring [i].tmd0 = leptr;
ib->btx_ring [i].tmd1_hadr = leptr >> 16;
@@ -399,7 +399,7 @@ static void lance_init_ring_pio(struct net_device *dev)
sbus_writeb(dev->dev_addr[4], &ib->phys_addr[5]);
/* Setup the Tx ring entries */
- for (i = 0; i <= TX_RING_SIZE; i++) {
+ for (i = 0; i < TX_RING_SIZE; i++) {
leptr = libbuff_offset(tx_buf, i);
sbus_writew(leptr, &ib->btx_ring [i].tmd0);
sbus_writeb(leptr >> 16,&ib->btx_ring [i].tmd1_hadr);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] sunlance: beyond ARRAY_SIZE of ib->btx_ring
2009-05-21 20:31 ` [PATCH] sunlance: beyond " Roel Kluin
@ 2009-05-21 20:34 ` David Miller
2009-05-21 22:02 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2009-05-21 20:34 UTC (permalink / raw)
To: roel.kluin; +Cc: jgarzik, akpm, netdev
From: Roel Kluin <roel.kluin@gmail.com>
Date: Thu, 21 May 2009 22:31:12 +0200
> Do not go beyond ARRAY_SIZE of ib->btx_ring
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Please ignore the other "X: ... patch"
You don't need to keep CC:'ing Jeff, he hasn't handled networking
device driver patches for some time now.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sunlance: beyond ARRAY_SIZE of ib->btx_ring
2009-05-21 20:31 ` [PATCH] sunlance: beyond " Roel Kluin
2009-05-21 20:34 ` David Miller
@ 2009-05-21 22:02 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2009-05-21 22:02 UTC (permalink / raw)
To: roel.kluin; +Cc: akpm, netdev
From: Roel Kluin <roel.kluin@gmail.com>
Date: Thu, 21 May 2009 22:31:12 +0200
> Do not go beyond ARRAY_SIZE of ib->btx_ring
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
What in the world are you generating this patch against?
Linus's tree already has this change, for months.
And it was added by you, in February!
commit b956d41162b1f2c4b446107e9910e4719cbc75f4
Author: Roel Kluin <roel.kluin@gmail.com>
Date: Sat Feb 21 23:46:36 2009 -0800
sunlance: Beyond ARRAY_SIZE of ib->btx_ring
Do not go beyond ARRAY_SIZE of ib->btx_ring
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-05-21 22:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-21 20:28 [PATCH] X:beyond ARRAY_SIZE of ib->btx_ring Roel Kluin
2009-05-21 20:31 ` [PATCH] sunlance: beyond " Roel Kluin
2009-05-21 20:34 ` David Miller
2009-05-21 22:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).