From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Riepe Subject: Re: [PATCH 2.6.30-rc4] r8169: avoid losing MSI interrupts Date: Sat, 23 May 2009 16:35:28 +0200 Message-ID: <4A1809B0.3030109@googlemail.com> References: <200903041828.49972.m.bueker@berlin.de> <4A0C7443.1010000@googlemail.com> <1243042174.3580.23.camel@obelisk.thedillows.org> <200905231124.28925.mb@bu3sch.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: David Dillow , Francois Romieu , Rui Santos , =?ISO-8859-15?Q?Michael_B=FCker?= , linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: Michael Buesch Return-path: Received: from fg-out-1718.google.com ([72.14.220.153]:46950 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752726AbZEWOfa (ORCPT ); Sat, 23 May 2009 10:35:30 -0400 In-Reply-To: <200905231124.28925.mb@bu3sch.de> Sender: netdev-owner@vger.kernel.org List-ID: Hi! Michael Buesch wrote: > Thanks a lot, Dave! This fixes the issue on my chip. Yep, it's stable here as well. And even a little faster than pci=nomsi. The only strangeness I observed is that the throughput (measured with iperf and a single TCP connection) varies: [ ID] Interval Transfer Bandwidth [ 3] 0.0-10.0 sec 667 MBytes 559 Mbits/sec [ 3] 10.0-20.0 sec 803 MBytes 673 Mbits/sec [ 3] 20.0-30.0 sec 802 MBytes 673 Mbits/sec [ 3] 30.0-40.0 sec 714 MBytes 599 Mbits/sec [ 3] 40.0-50.0 sec 669 MBytes 561 Mbits/sec [ 3] 50.0-60.0 sec 791 MBytes 663 Mbits/sec [ 3] 0.0-60.0 sec 4.34 GBytes 622 Mbits/sec In gkrellm, you can see that it actually alternates between two values. With pci=nomsi (and without the patch) I get lower but more consistent results: [ ID] Interval Transfer Bandwidth [ 3] 0.0-10.0 sec 511 MBytes 429 Mbits/sec [ 3] 10.0-20.0 sec 465 MBytes 390 Mbits/sec [ 3] 20.0-30.0 sec 481 MBytes 404 Mbits/sec [ 3] 30.0-40.0 sec 466 MBytes 391 Mbits/sec [ 3] 40.0-50.0 sec 465 MBytes 390 Mbits/sec [ 3] 50.0-60.0 sec 463 MBytes 389 Mbits/sec [ 3] 0.0-60.0 sec 2.78 GBytes 399 Mbits/sec I suppose it's a side effect of the MSI acknowledgement loop. But who am I to complain about higher average throughput? ;-) > You can add my: > > Tested-by: Michael Buesch Tested-by: Michael Riepe -- Michael "Tired" Riepe X-Tired: Each morning I get up I die a little