* [PATCH] gigaset: beyond ARRAY_SIZE of iwb->data
@ 2009-05-21 20:32 Roel Kluin
2009-05-21 22:04 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Roel Kluin @ 2009-05-21 20:32 UTC (permalink / raw)
To: hjlipp; +Cc: gigaset307x-common, netdev, Andrew Morton
Do not go beyond ARRAY_SIZE of iwb->data
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Sorry for the dup, the header was incorrect. This is against linux-next.
diff --git a/drivers/isdn/gigaset/isocdata.c b/drivers/isdn/gigaset/isocdata.c
index fbce522..5569a6e 100644
--- a/drivers/isdn/gigaset/isocdata.c
+++ b/drivers/isdn/gigaset/isocdata.c
@@ -177,7 +177,7 @@ int gigaset_isowbuf_getbytes(struct isowbuf_t *iwb, int size)
return -EINVAL;
}
src = iwb->read;
- if (unlikely(limit > BAS_OUTBUFSIZE + BAS_OUTBUFPAD ||
+ if (unlikely(limit >= BAS_OUTBUFSIZE + BAS_OUTBUFPAD ||
(read < src && limit >= src))) {
err("isoc write buffer frame reservation violated");
return -EFAULT;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] gigaset: beyond ARRAY_SIZE of iwb->data
2009-05-21 20:32 [PATCH] gigaset: beyond ARRAY_SIZE of iwb->data Roel Kluin
@ 2009-05-21 22:04 ` David Miller
2009-05-25 10:00 ` Tilman Schmidt
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2009-05-21 22:04 UTC (permalink / raw)
To: roel.kluin; +Cc: hjlipp, gigaset307x-common, netdev, akpm
From: Roel Kluin <roel.kluin@gmail.com>
Date: Thu, 21 May 2009 22:32:54 +0200
> Do not go beyond ARRAY_SIZE of iwb->data
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> Sorry for the dup, the header was incorrect. This is against linux-next.
Applied to net-2.6
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gigaset: beyond ARRAY_SIZE of iwb->data
2009-05-21 22:04 ` David Miller
@ 2009-05-25 10:00 ` Tilman Schmidt
0 siblings, 0 replies; 3+ messages in thread
From: Tilman Schmidt @ 2009-05-25 10:00 UTC (permalink / raw)
To: David Miller; +Cc: roel.kluin, netdev, akpm, gigaset307x-common, hjlipp
[-- Attachment #1: Type: text/plain, Size: 744 bytes --]
Am 22.05.2009 00:04 schrieb David Miller:
> From: Roel Kluin <roel.kluin@gmail.com>
> Date: Thu, 21 May 2009 22:32:54 +0200
>
>> Do not go beyond ARRAY_SIZE of iwb->data
>>
>> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
>> ---
>> Sorry for the dup, the header was incorrect. This is against linux-next.
>
> Applied to net-2.6
Thanks for the CC. Unfortunately I didn't receive the original patch, nor
can I find it on LKML. Could someone send me a copy please so that I can
check it before it gets merged?
Thanks,
Tilman
--
Tilman Schmidt E-Mail: tilman@imap.cc
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 254 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-05-25 10:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-21 20:32 [PATCH] gigaset: beyond ARRAY_SIZE of iwb->data Roel Kluin
2009-05-21 22:04 ` David Miller
2009-05-25 10:00 ` Tilman Schmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).