* [SCSI] cxgb3i: Include net/dst.h for struct dst_cache
@ 2009-05-30 3:40 Herbert Xu
2009-06-01 2:25 ` Mike Christie
0 siblings, 1 reply; 2+ messages in thread
From: Herbert Xu @ 2009-05-30 3:40 UTC (permalink / raw)
To: Mike Christie, James Bottomley, linux-scsi, netdev
Hi:
[SCSI] cxgb3i: Include net/dst.h for struct dst_cache
This driver needs dst_cache->dev so it should include net/dst.h
to ensure that it builds. While net/tcp.h probably includes it
already, we shouldn't rely on that since there is no guarantee
that this won't change in future.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/drivers/scsi/cxgb3i/cxgb3i_iscsi.c b/drivers/scsi/cxgb3i/cxgb3i_iscsi.c
index 9212400..8b49731 100644
--- a/drivers/scsi/cxgb3i/cxgb3i_iscsi.c
+++ b/drivers/scsi/cxgb3i/cxgb3i_iscsi.c
@@ -13,6 +13,7 @@
#include <linux/inet.h>
#include <linux/crypto.h>
+#include <net/dst.h>
#include <net/tcp.h>
#include <scsi/scsi_cmnd.h>
#include <scsi/scsi_device.h>
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [SCSI] cxgb3i: Include net/dst.h for struct dst_cache
2009-05-30 3:40 [SCSI] cxgb3i: Include net/dst.h for struct dst_cache Herbert Xu
@ 2009-06-01 2:25 ` Mike Christie
0 siblings, 0 replies; 2+ messages in thread
From: Mike Christie @ 2009-06-01 2:25 UTC (permalink / raw)
To: Herbert Xu; +Cc: James Bottomley, linux-scsi, netdev, Karen Xie
ccing cxgb3i driver maitainer.
Herbert Xu wrote:
> Hi:
>
> [SCSI] cxgb3i: Include net/dst.h for struct dst_cache
>
> This driver needs dst_cache->dev so it should include net/dst.h
> to ensure that it builds. While net/tcp.h probably includes it
> already, we shouldn't rely on that since there is no guarantee
> that this won't change in future.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> diff --git a/drivers/scsi/cxgb3i/cxgb3i_iscsi.c b/drivers/scsi/cxgb3i/cxgb3i_iscsi.c
> index 9212400..8b49731 100644
> --- a/drivers/scsi/cxgb3i/cxgb3i_iscsi.c
> +++ b/drivers/scsi/cxgb3i/cxgb3i_iscsi.c
> @@ -13,6 +13,7 @@
>
> #include <linux/inet.h>
> #include <linux/crypto.h>
> +#include <net/dst.h>
> #include <net/tcp.h>
> #include <scsi/scsi_cmnd.h>
> #include <scsi/scsi_device.h>
>
Looks ok.
Acked-by: Mike Christie <michaelc@cs.wisc.edu>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-01 2:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-30 3:40 [SCSI] cxgb3i: Include net/dst.h for struct dst_cache Herbert Xu
2009-06-01 2:25 ` Mike Christie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).