From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH iproute2] Re: HTB accuracy for high speed
Date: Wed, 03 Jun 2009 12:06:10 +0200
Message-ID: <4A264B12.5030303@trash.net>
References: <298f5c050906020445n3941b4ceic1167a4a028005bf@mail.gmail.com> <20090602123635.GC4239@ff.dom.local> <4A251EEE.4060903@trash.net> <20090602130857.GA7690@ff.dom.local> <4A252714.2020008@trash.net> <20090602213723.GB2850@ami.dom.local> <4A259EB2.5010500@gmail.com> <4A2620FD.8030708@trash.net> <20090603074049.GA5254@ff.dom.local> <4A262BE7.4090807@trash.net> <20090603095412.GC5644@ff.dom.local> <4A264A13.3030005@trash.net> <4A264AE8.2050105@trash.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Antonio Almeida <vexwek@gmail.com>,
	Stephen Hemminger <shemminger@vyatta.com>,
	netdev@vger.kernel.org, davem@davemloft.net, devik@cdi.cz,
	Eric Dumazet <dada1@cosmosbay.com>,
	Vladimir Ivashchenko <hazard@francoudi.com>
To: Jarek Poplawski <jarkao2@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from stinky.trash.net ([213.144.137.162]:62982 "EHLO
	stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752107AbZFCKGJ (ORCPT
	<rfc822;netdev@vger.kernel.org>); Wed, 3 Jun 2009 06:06:09 -0400
In-Reply-To: <4A264AE8.2050105@trash.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Patrick McHardy wrote:
>> PSCHED_SHIFT should be 4, right?
> 
>> -#define    SM_SHIFT    20
>> -#define    ISM_SHIFT    18
>> +#define    PSCHED_SHIFT    6    /* TODO: move to pkt_sched.h */
>> +#define    SM_SHIFT    (30 - PSCHED_SHIFT)
>> +#define    ISM_SHIFT    (8 + PSCHED_SHIFT)
> 
> Actually I'm confused, why the additional change of 10?

OK, 10 - 6 = 4, got it :)