netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rick Jones <rick.jones2@hp.com>
To: "Zou, Yi" <yi.zou@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"Leech, Christopher" <christopher.leech@intel.com>,
	"Dev, Vasu" <vasu.dev@intel.com>,
	"Love, Robert W" <robert.w.love@intel.com>,
	"Ma, Steve" <steve.ma@intel.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
Subject: Re: Question regarding protocol specific mtu for FCoE
Date: Wed, 03 Jun 2009 14:01:34 -0700	[thread overview]
Message-ID: <4A26E4AE.4020607@hp.com> (raw)
In-Reply-To: <7C88852EF6F99F4EB538472FCFEBE2223A7E6FBD@orsmsx509.amr.corp.intel.com>

>> Do FCoE upper layers have anything analagous to a TCP_MAXSEG option? That
>> allows an application using TCP to ask for a smaller MSS than TCP might have
>>  chosen otherwise.
> 
> No, FCoE does not have that. The current kernel FCoE initiator initiates its
> max frame size based on the associated netdev->mtu, which normally is 1500.
> So, unless the LAN mtu is changed, FCoE stack is no able to use baby jumbo
> frame.

So FCoE cannot say "fcoe_mtu = min(OPTIMAL_FCOEMTU,netdev->mtu)" and send-down 
frames based on that?

>> Would a NIC over which FCoE was running be able to be of two minds of what 
>> the MTU happens to be?  I'd think that if one user of the NIC needed/wanted
>>  and MTU > foo one would just set the MTU large enough to include foo and be
>>  done with it?
> 
> For a nic that supports converged traffic, i.e. LAN + FCoE, I think
> it's safe to assume the nic has that capability. Setting LAN MTU large
> enough will work for FCoE, but it affects everyone using netdev->mtu, so
> you may see degraded LAN performance, which is certainly not good.

There have been some instances of increased MTU running causing applcations to 
run afoul of Nagle and what not, but I don't think it is a general truism that 
using a larger MTU degrades LAN performance.

Perhaps it is just me not getting out enough but I'm still having trouble coming 
to grips with the idea of a NIC that has two (or more) ideas of a valid frame 
size based on ethertype or whatnot.

At the risk of another of my "Emily Litella" moments, it sounds like the NIC HW 
will have to be set to use an MTU that is the max of the desired IP and FCoE MTUs 
and so you are not really talking about adding one MTU concept but two so you have:

1) the "HW MTU" used by the NIC and the guts of the driver
2) the legacy networking (eg IP etc) MTU passed up through the legacy path
3) the fcoe MTU passed up through the fcoe path

where 1 is the max of 2,3

rick jones

  parent reply	other threads:[~2009-06-03 21:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-03 17:56 Question regarding protocol specific mtu for FCoE Zou, Yi
2009-06-03 18:03 ` Rick Jones
2009-06-03 19:16   ` Zou, Yi
2009-06-03 19:27     ` Ben Hutchings
2009-06-03 20:43       ` Zou, Yi
2009-06-03 20:57         ` Ben Hutchings
2009-06-03 22:22           ` Zou, Yi
2009-06-03 21:01     ` Rick Jones [this message]
2009-06-03 21:17       ` Waskiewicz Jr, Peter P
2009-06-03 21:21       ` Roland Dreier
2009-06-03 22:25         ` Zou, Yi
2009-06-03 22:36         ` Rick Jones
2009-06-03 23:00           ` Zou, Yi
2009-06-03 23:27           ` Roland Dreier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A26E4AE.4020607@hp.com \
    --to=rick.jones2@hp.com \
    --cc=christopher.leech@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=robert.w.love@intel.com \
    --cc=steve.ma@intel.com \
    --cc=vasu.dev@intel.com \
    --cc=yi.zou@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).