From: Michael Tokarev <mjt@tls.msk.ru>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Linux-kernel <linux-kernel@vger.kernel.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [Security, resend] Instant crash with rtl8169 and large packets
Date: Mon, 08 Jun 2009 23:28:54 +0400 [thread overview]
Message-ID: <4A2D6676.1030607@msgid.tls.msk.ru> (raw)
In-Reply-To: <4A2D4AA7.6020204@gmail.com>
Eric Dumazet wrote:
> OK I suspect driver is buggy since 2.6.10 days :)
I browsed the git history for a while but don't see since
when it might be broken. But again, I don't know the code
nor the hardware.
> Could you try this patch ?
That makes quite some sense, except of two comments - pure
speculation/guesses really, since I don't know the hw.
The patch does not re-program the card when we change MTU
(where we merely set internal rx_buf_sz, but don't tell the
card about this). Maybe we should call this method in
rtl8169_set_rxbufsize() too?
I don't know almost anything about things like vlans for
example, but guess they use some additional headers. Does
those need some space too? Maybe its better to allocate
"a bit" more room in skb for that stuff?
Recompiling the driver now...
/mjt
next prev parent reply other threads:[~2009-06-08 19:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-08 13:25 [Security, resend] Instant crash with rtl8169 and large packets Michael Tokarev
2009-06-08 14:27 ` Eric Dumazet
2009-06-08 14:53 ` Michael Tokarev
2009-06-08 15:06 ` Eric Dumazet
2009-06-08 15:37 ` Michael Tokarev
2009-06-08 15:59 ` Eric Dumazet
2009-06-08 16:26 ` Michael Tokarev
2009-06-08 17:30 ` Eric Dumazet
2009-06-08 19:28 ` Michael Tokarev [this message]
2009-06-08 19:57 ` Michael Tokarev
2009-06-08 21:17 ` Eric Dumazet
2009-06-08 21:27 ` Michael Tokarev
2009-06-09 11:20 ` Krzysztof Halasa
2009-06-08 22:02 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2D6676.1030607@msgid.tls.msk.ru \
--to=mjt@tls.msk.ru \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).