netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
To: Ingo <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>, David Miller <davem@
Subject: [PATCH RESEND] ftrace: change the export format of trace_kfree_skb()
Date: Tue, 09 Jun 2009 13:54:39 +0800	[thread overview]
Message-ID: <4A2DF91F.7030906@cn.fujitsu.com> (raw)

Use %pf instead of %p to output the function's address, use 0x%04X instead
of %u to output the skb's protocol

Before patch:

          <idle>-0     [000] 60144.542521: kfree_skb: skbaddr=de7b8240 protocol=2048 location=c1365429
          <idle>-0     [000] 60164.488153: kfree_skb: skbaddr=da66f900 protocol=2048 location=c1365429
          <idle>-0     [000] 60193.493933: kfree_skb: skbaddr=deaeb480 protocol=4 location=c134ec25
          <idle>-0     [000] 60253.118421: kfree_skb: skbaddr=de7c4900 protocol=4 location=c134ec25
          
After patch:

            bash-2587  [001] 97685.781173: kfree_skb: skbaddr=deb9cc00 protocol=0x0000 location=netlink_unicast
            bash-2587  [000] 97686.501121: kfree_skb: skbaddr=df9bb840 protocol=0x0000 location=netlink_unicast
          <idle>-0     [000] 97696.200184: kfree_skb: skbaddr=df741240 protocol=0x0800 location=ip_rcv
          <idle>-0     [000] 97696.200198: kfree_skb: skbaddr=dfb3de40 protocol=0x0800 location=ip_rcv

Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
---

Recover the file mode of include/trace/events/skb.h

---
 include/trace/events/skb.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/trace/events/skb.h b/include/trace/events/skb.h
index 1e8fabb..a58bef8 100644
--- a/include/trace/events/skb.h
+++ b/include/trace/events/skb.h
@@ -30,7 +30,7 @@ TRACE_EVENT(kfree_skb,
 		__entry->location = location;
 	),
 
-	TP_printk("skbaddr=%p protocol=%u location=%p",
+	TP_printk("skbaddr=%p protocol=0x%04X location=%pf",
 		__entry->skbaddr, __entry->protocol, __entry->location)
 );
 
-- 
1.6.1.2


             reply	other threads:[~2009-06-09  5:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-09  5:54 Xiao Guangrong [this message]
2009-06-09 18:27 ` [PATCH RESEND] ftrace: change the export format of trace_kfree_skb() Frederic Weisbecker
2009-06-10  1:40   ` Xiao Guangrong
2009-06-10  1:56     ` Steven Rostedt
2009-06-10  7:26     ` Frederic Weisbecker
2009-06-18  3:26       ` [PATCH v2] " Xiao Guangrong
2009-06-18 10:35         ` Neil Horman
2009-06-18 12:51           ` Steven Rostedt
2009-06-18 14:08             ` Neil Horman
2009-06-24  6:58           ` David Miller
2009-06-26  1:24             ` Xiao Guangrong
2009-06-19  0:33         ` Steven Rostedt
2009-06-19  2:05           ` Xiao Guangrong
2009-06-19  2:11             ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2DF91F.7030906@cn.fujitsu.com \
    --to=xiaoguangrong@cn.fujitsu.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=netdev@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).