netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: Stephen Hemminger <shemminger@vyatta.com>,
	Arnd Bergmann <arnd@arndb.de>,
	"David S. Miller" <davem@davemloft.net>,
	bonding-devel@lists.sf.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: BUG: bonding module can only be loaded once
Date: Tue, 09 Jun 2009 18:27:14 +0200	[thread overview]
Message-ID: <4A2E8D62.6090004@trash.net> (raw)
In-Reply-To: <4752.1244564082@death.nxdomain.ibm.com>

Jay Vosburgh wrote:
> Patrick McHardy <kaber@trash.net> wrote:
> 
>> In any case, this is not the first time this has been broken and the
>> fundamental reason is in my opinion that the bonding interface is
>> broken to begin with. The module aliasing thing is complete crap
>> and should have been phased out long ago. At this point its probably
>> not worth anymore to migrate people to the sysfs interface though,
>> the best thing would be to add an rtnl_link interface and phase out
>> both.
> 
> 	The "load bonding multiple times" stuff is only there now for
> backwards compatibility with old distro initscripts / sysconfig packages
> that don't configure bonding through sysfs (a sysfs API was added to
> bonding three or four years ago).
> 
> 	All of the current distro releases I'm aware of use sysfs to
> configure bonding, and have done so for at least a year or two.  I
> haven't done an exhaustive survey, but it seems unlikely that users are
> running a current up to date kernel with a two or three year old
> initscripts / sysconfig package.  Anybody have information to the
> contrary?

I'd expect its not the distros, but rather the applicances which might
still be using this. I know a vendor I used to work for a couple of
years ago just recently made the switch from 2.6.16 to a current kernel,
and I'd expect that they are still using this (I can find out tommorrow
if you want to know for sure). Vyatta likewise, I guess.

> 	If nobody has any heartburn at dropping support for multiple
> bonding instances on old distros, I'm as happy as anybody to remove all
> of the multiple load logic from bonding.  There's been plenty of time
> for transitioning from "multiple load" to sysfs.

In my opinion it would need a feature-removal-schedule announcement.

  reply	other threads:[~2009-06-09 16:27 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-08 22:11 BUG: bonding module can only be loaded once Stephen Hemminger
2009-06-09 12:06 ` Arnd Bergmann
2009-06-09 15:02   ` Stephen Hemminger
2009-06-09 15:33     ` Patrick McHardy
2009-06-09 16:14       ` Jay Vosburgh
2009-06-09 16:27         ` Patrick McHardy [this message]
2009-06-09 17:23           ` [PATCH] bonding: fix multiple module load problem Stephen Hemminger
2009-06-09 17:37             ` [Bonding-devel] " Jay Vosburgh
2009-06-09 17:24           ` [Bonding-devel] BUG: bonding module can only be loaded once Jay Vosburgh
2009-06-09 22:14             ` Patrick McHardy
2009-06-10 13:19               ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2E8D62.6090004@trash.net \
    --to=kaber@trash.net \
    --cc=arnd@arndb.de \
    --cc=bonding-devel@lists.sf.net \
    --cc=davem@davemloft.net \
    --cc=fubar@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).