From: Patrick McHardy <kaber@trash.net>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC vlan 03/03]: propagate transmission state
Date: Tue, 09 Jun 2009 18:37:22 +0200 [thread overview]
Message-ID: <4A2E8FC2.2030100@trash.net> (raw)
In-Reply-To: <4A2E8F27.3040202@gmail.com>
Eric Dumazet wrote:
> Patrick McHardy a écrit :
>> static int vlan_dev_hwaccel_hard_start_xmit(struct sk_buff *skb,
>> struct net_device *dev)
>> {
>> struct netdev_queue *txq = netdev_get_tx_queue(dev, 0);
>> + unsigned int len;
>> u16 vlan_tci;
>> + int err;
>>
>> vlan_tci = vlan_dev_info(dev)->vlan_id;
>> vlan_tci |= vlan_dev_get_egress_qos_mask(dev, skb);
>> @@ -339,8 +347,15 @@ static int vlan_dev_hwaccel_hard_start_xmit(struct sk_buff *skb,
>> txq->tx_bytes += skb->len;
>
> It seems you forgot to delete previous txq->tx_bytes += skb->len; && txq->tx_packets++; ?
Indeed, thanks, I've fixed it in my tree.
next prev parent reply other threads:[~2009-06-09 16:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 16:16 [RFC net 00/03]: dev_queue_xmit error propagation Patrick McHardy
2009-06-09 16:17 ` [RFC net-sched 01/03]: use symbolic NET_XMIT constants in qdiscs Patrick McHardy
2009-06-09 16:17 ` [RFC net 02/03]: allow to propagate errors through ->ndo_hard_start_xmit() Patrick McHardy
2009-06-16 9:25 ` Jarek Poplawski
2009-06-19 12:23 ` Patrick McHardy
2009-06-09 16:17 ` [RFC vlan 03/03]: propagate transmission state Patrick McHardy
2009-06-09 16:34 ` Eric Dumazet
2009-06-09 16:37 ` Patrick McHardy [this message]
2009-06-11 10:18 ` [RFC net 00/03]: dev_queue_xmit error propagation David Miller
2009-06-11 16:33 ` Patrick McHardy
2009-06-12 0:05 ` David Miller
2009-06-12 0:10 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2E8FC2.2030100@trash.net \
--to=kaber@trash.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).