* [PATCH] r8169: use dev_kfree_skb() instead of dev_kfree_skb_irq()
@ 2009-06-10 8:55 Eric Dumazet
2009-06-11 9:50 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2009-06-10 8:55 UTC (permalink / raw)
To: David S. Miller; +Cc: Linux Netdev List, Michael Tokarev
rtl8169_tx_interrupt() is used from NAPI context, it can
directly free skbs. dev_kfree_skb_irq() is a leftover from
pre-NAPI times of this driver.
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c
index e94316b..007c881 100644
--- a/drivers/net/r8169.c
+++ b/drivers/net/r8169.c
@@ -3379,7 +3379,7 @@ static void rtl8169_tx_interrupt(struct net_device *dev,
rtl8169_unmap_tx_skb(tp->pci_dev, tx_skb, tp->TxDescArray + entry);
if (status & LastFrag) {
- dev_kfree_skb_irq(tx_skb->skb);
+ dev_kfree_skb(tx_skb->skb);
tx_skb->skb = NULL;
}
dirty_tx++;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] r8169: use dev_kfree_skb() instead of dev_kfree_skb_irq()
2009-06-10 8:55 [PATCH] r8169: use dev_kfree_skb() instead of dev_kfree_skb_irq() Eric Dumazet
@ 2009-06-11 9:50 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-06-11 9:50 UTC (permalink / raw)
To: eric.dumazet; +Cc: netdev, mjt
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 10 Jun 2009 10:55:53 +0200
> rtl8169_tx_interrupt() is used from NAPI context, it can
> directly free skbs. dev_kfree_skb_irq() is a leftover from
> pre-NAPI times of this driver.
>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-11 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-10 8:55 [PATCH] r8169: use dev_kfree_skb() instead of dev_kfree_skb_irq() Eric Dumazet
2009-06-11 9:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).