From: Badalian Vyacheslav <slavon@bigtelecom.ru>
To: netdev <netdev@vger.kernel.org>
Subject: Re: [net-next PATCH 1/5] be2net: Use cancel_delayed_work_sync instead of cancel_delayed_work()
Date: Wed, 10 Jun 2009 16:21:11 +0400 [thread overview]
Message-ID: <4A2FA537.7080709@bigtelecom.ru> (raw)
In-Reply-To: <20090610121835.GA16411@serverengines.com>
Typo in desctription:
"Use cancel_delayed_work_sycn" -> "Use cancel_delayed_work_sync"
Thanks
> Use cancel_delayed_work_sycn instead of cancel_delayed_work() to reliably kill be_worker() as it rearms itself.
>
> Signed-off-by: Sathya Perla <sathyap@serverengines.com>
> ---
> drivers/net/benet/be_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c
> index 347d002..69046a1 100644
> --- a/drivers/net/benet/be_main.c
> +++ b/drivers/net/benet/be_main.c
> @@ -1533,7 +1533,7 @@ static int be_close(struct net_device *netdev)
> struct be_eq_obj *tx_eq = &adapter->tx_eq;
> int vec;
>
> - cancel_delayed_work(&adapter->work);
> + cancel_delayed_work_sync(&adapter->work);
>
> netif_stop_queue(netdev);
> netif_carrier_off(netdev);
>
next prev parent reply other threads:[~2009-06-10 12:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 12:18 [net-next PATCH 1/5] be2net: Use cancel_delayed_work_sync instead of cancel_delayed_work() Sathya Perla
2009-06-10 12:21 ` Badalian Vyacheslav [this message]
2009-06-11 9:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A2FA537.7080709@bigtelecom.ru \
--to=slavon@bigtelecom.ru \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).