* [net-next PATCH 1/5] be2net: Use cancel_delayed_work_sync instead of cancel_delayed_work()
@ 2009-06-10 12:18 Sathya Perla
2009-06-10 12:21 ` Badalian Vyacheslav
2009-06-11 9:49 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Sathya Perla @ 2009-06-10 12:18 UTC (permalink / raw)
To: netdev
Use cancel_delayed_work_sycn instead of cancel_delayed_work() to reliably kill be_worker() as it rearms itself.
Signed-off-by: Sathya Perla <sathyap@serverengines.com>
---
drivers/net/benet/be_main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c
index 347d002..69046a1 100644
--- a/drivers/net/benet/be_main.c
+++ b/drivers/net/benet/be_main.c
@@ -1533,7 +1533,7 @@ static int be_close(struct net_device *netdev)
struct be_eq_obj *tx_eq = &adapter->tx_eq;
int vec;
- cancel_delayed_work(&adapter->work);
+ cancel_delayed_work_sync(&adapter->work);
netif_stop_queue(netdev);
netif_carrier_off(netdev);
--
1.6.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [net-next PATCH 1/5] be2net: Use cancel_delayed_work_sync instead of cancel_delayed_work()
2009-06-10 12:18 [net-next PATCH 1/5] be2net: Use cancel_delayed_work_sync instead of cancel_delayed_work() Sathya Perla
@ 2009-06-10 12:21 ` Badalian Vyacheslav
2009-06-11 9:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Badalian Vyacheslav @ 2009-06-10 12:21 UTC (permalink / raw)
To: netdev
Typo in desctription:
"Use cancel_delayed_work_sycn" -> "Use cancel_delayed_work_sync"
Thanks
> Use cancel_delayed_work_sycn instead of cancel_delayed_work() to reliably kill be_worker() as it rearms itself.
>
> Signed-off-by: Sathya Perla <sathyap@serverengines.com>
> ---
> drivers/net/benet/be_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c
> index 347d002..69046a1 100644
> --- a/drivers/net/benet/be_main.c
> +++ b/drivers/net/benet/be_main.c
> @@ -1533,7 +1533,7 @@ static int be_close(struct net_device *netdev)
> struct be_eq_obj *tx_eq = &adapter->tx_eq;
> int vec;
>
> - cancel_delayed_work(&adapter->work);
> + cancel_delayed_work_sync(&adapter->work);
>
> netif_stop_queue(netdev);
> netif_carrier_off(netdev);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [net-next PATCH 1/5] be2net: Use cancel_delayed_work_sync instead of cancel_delayed_work()
2009-06-10 12:18 [net-next PATCH 1/5] be2net: Use cancel_delayed_work_sync instead of cancel_delayed_work() Sathya Perla
2009-06-10 12:21 ` Badalian Vyacheslav
@ 2009-06-11 9:49 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2009-06-11 9:49 UTC (permalink / raw)
To: sathyap; +Cc: netdev
From: Sathya Perla <sathyap@serverengines.com>
Date: Wed, 10 Jun 2009 17:48:35 +0530
> Use cancel_delayed_work_sycn instead of cancel_delayed_work() to reliably kill be_worker() as it rearms itself.
>
> Signed-off-by: Sathya Perla <sathyap@serverengines.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-11 9:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-10 12:18 [net-next PATCH 1/5] be2net: Use cancel_delayed_work_sync instead of cancel_delayed_work() Sathya Perla
2009-06-10 12:21 ` Badalian Vyacheslav
2009-06-11 9:49 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).