Re: linux-next: Tree for June 11 (cnic)

Re: linux-next: Tree for June 11 (cnic)

[Randy Dunlap]

Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20090610:


In 2 separate builds:

ERROR: "ip_route_output_key" [drivers/net/cnic.ko] undefined!

when CONFIG_INET=n

and

drivers/net/cnic.c:2520: error: implicit declaration of function '__symbol_get'

when CONFIG_MODULES=n


-- 
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/

[PATCH -next] ieee802154: fix kconfig bool/tristate muckup

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

menuconfig IEEE802154_DRIVERS is a bool that depends on tristate IEEE802154.
If the IEEE802154 symbol is 'm', the bool becomes 'y'.
This allows tristate symbols under IEEE802154_DRIVERS to be configured as
'y' and cause build problems.
Changing the menuconfig bool to a tristate fixes this.

drivers/built-in.o: In function `fake_scan_req':
fakehard.c:(.text+0x46d625): undefined reference to `ieee802154_nl_scan_confirm'
drivers/built-in.o: In function `fake_disassoc_req':
fakehard.c:(.text+0x46d66f): undefined reference to `ieee802154_nl_disassoc_confirm'
drivers/built-in.o: In function `fake_assoc_req':
fakehard.c:(.text+0x46d6be): undefined reference to `ieee802154_nl_assoc_confirm'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-zigbee-devel@lists.sourceforge.net
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Cc: Sergey Lapin <slapin@ossfans.org>
---
 drivers/ieee802154/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20090612.orig/drivers/ieee802154/Kconfig
+++ linux-next-20090612/drivers/ieee802154/Kconfig
@@ -1,5 +1,5 @@
 menuconfig IEEE802154_DRIVERS
-	bool "IEEE 802.15.4 drivers"
+	tristate "IEEE 802.15.4 drivers"
 	depends on NETDEVICES && IEEE802154
 	default y
 	---help---


-- 
~Randy
LPC 2009, Sept. 23-25, Portland, Oregon
http://linuxplumbersconf.org/2009/

Re: [PATCH -next] ieee802154: fix kconfig bool/tristate muckup

[Sergey Lapin]

On Fri, Jun 12, 2009 at 03:59:20PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> menuconfig IEEE802154_DRIVERS is a bool that depends on tristate IEEE802154.
> If the IEEE802154 symbol is 'm', the bool becomes 'y'.
> This allows tristate symbols under IEEE802154_DRIVERS to be configured as
> 'y' and cause build problems.
> Changing the menuconfig bool to a tristate fixes this.
> 
> drivers/built-in.o: In function `fake_scan_req':
> fakehard.c:(.text+0x46d625): undefined reference to `ieee802154_nl_scan_confirm'
> drivers/built-in.o: In function `fake_disassoc_req':
> fakehard.c:(.text+0x46d66f): undefined reference to `ieee802154_nl_disassoc_confirm'
> drivers/built-in.o: In function `fake_assoc_req':
> fakehard.c:(.text+0x46d6be): undefined reference to `ieee802154_nl_assoc_confirm'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: linux-zigbee-devel@lists.sourceforge.net
> Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> Cc: Sergey Lapin <slapin@ossfans.org>
Ackedy-by: Sergey Lapin <slapin@ossfans.org>

Thanks a lot!
S.

Re: [PATCH -next] ieee802154: fix kconfig bool/tristate muckup

[David Miller]

From: Sergey Lapin <slapin@ossfans.org>
Date: Sat, 13 Jun 2009 14:57:54 +0400

> On Fri, Jun 12, 2009 at 03:59:20PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>> 
>> menuconfig IEEE802154_DRIVERS is a bool that depends on tristate IEEE802154.
>> If the IEEE802154 symbol is 'm', the bool becomes 'y'.
>> This allows tristate symbols under IEEE802154_DRIVERS to be configured as
>> 'y' and cause build problems.
>> Changing the menuconfig bool to a tristate fixes this.
>> 
>> drivers/built-in.o: In function `fake_scan_req':
>> fakehard.c:(.text+0x46d625): undefined reference to `ieee802154_nl_scan_confirm'
>> drivers/built-in.o: In function `fake_disassoc_req':
>> fakehard.c:(.text+0x46d66f): undefined reference to `ieee802154_nl_disassoc_confirm'
>> drivers/built-in.o: In function `fake_assoc_req':
>> fakehard.c:(.text+0x46d6be): undefined reference to `ieee802154_nl_assoc_confirm'
>> 
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>> Cc: linux-zigbee-devel@lists.sourceforge.net
>> Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
>> Cc: Sergey Lapin <slapin@ossfans.org>
> Ackedy-by: Sergey Lapin <slapin@ossfans.org>

It's "Acked-by:" :-)

Applied, thanks everyone.

Re: linux-next: Tree for June 11 (cnic)

[Kamalesh Babulal]

* Randy Dunlap <randy.dunlap@oracle.com> [2009-06-11 15:21:12]:

> Stephen Rothwell wrote:
> > Hi all,
> > 
> > Changes since 20090610:
> 
> 
> In 2 separate builds:
> 
> ERROR: "ip_route_output_key" [drivers/net/cnic.ko] undefined!
> 
> when CONFIG_INET=n
> 
> and
> 
> drivers/net/cnic.c:2520: error: implicit declaration of function '__symbol_get'
> 
> when CONFIG_MODULES=n

this build failure is also visible with 20090618.
> 
> 
> -- 
> ~Randy
> LPC 2009, Sept. 23-25, Portland, Oregon
> http://linuxplumbersconf.org/2009/

-- 
Kamalesh